Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2508433002: add object Printer for JSArrayIterator (Closed)

Created:
4 years, 1 month ago by caitp
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

add object Printer for JSArrayIterator BUG=v8:5635 R=mlippautz@chromium.org, bmeurer@chromium.org Committed: https://crrev.com/45bd43b8af6b2b6ad2ff4474f39e3b742a15616e Cr-Commit-Position: refs/heads/master@{#41006}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -0 lines) Patch
M src/objects-printer.cc View 2 chunks +58 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
caitp
one object printer as requested. I'm surprised there were no linker errors on any of ...
4 years, 1 month ago (2016-11-15 16:53:52 UTC) #3
Benedikt Meurer
LGTM. FYI vogelheim@: This needs to be back-merged if we pick a candidate that doesn't ...
4 years, 1 month ago (2016-11-15 17:22:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508433002/1
4 years, 1 month ago (2016-11-15 17:24:14 UTC) #9
Michael Lippautz
lgtm (we could get rid of the default case so the compiler could warn us ...
4 years, 1 month ago (2016-11-15 17:29:33 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-15 17:29:42 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:34:50 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/45bd43b8af6b2b6ad2ff4474f39e3b742a15616e
Cr-Commit-Position: refs/heads/master@{#41006}

Powered by Google App Engine
This is Rietveld 408576698