Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
250843008:
Remove telemetry_unittests from Android dbg tests. (Closed)
|
Created:
6 years, 7 months ago by navabi Modified:
6 years, 7 months ago CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionRemove telemetry_unittests from Android dbg tests.
BUG=366899
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267166
Patch Set 1 #Patch Set 2 : Still run telemetry tests on rel. #
Total comments: 2
Messages
Total messages: 30 (0 generated)
I'm confused, it looks to me like this removes the tests from all android configurations. The goal is to keep Release and remove Debug.
On 2014/04/29 13:05:31, tonyg wrote: > I'm confused, it looks to me like this removes the tests from all android > configurations. The goal is to keep Release and remove Debug. That's correct. The dbg and rel testers (i.e. bot id main-tests-(rel/dbg)) run the same set of tests . The new patch will run telemetry_perf_unittests on the rel main waterfall tester and the rel try tester. The try jobs for this patch should show where the tests run.
https://codereview.chromium.org/250843008/diff/20001/build/android/buildbot/b... File build/android/buildbot/bb_run_bot.py (right): https://codereview.chromium.org/250843008/diff/20001/build/android/buildbot/b... build/android/buildbot/bb_run_bot.py:204: ('try-tests-rel', 'main-tests-rel'), I don't understand how this is set up. Looks like the -rel and -dbg strings are magically respected by the right bots? If so, lgtm :)
https://codereview.chromium.org/250843008/diff/20001/build/android/buildbot/b... File build/android/buildbot/bb_run_bot.py (right): https://codereview.chromium.org/250843008/diff/20001/build/android/buildbot/b... build/android/buildbot/bb_run_bot.py:204: ('try-tests-rel', 'main-tests-rel'), On 2014/04/29 16:51:45, tonyg wrote: > I don't understand how this is set up. Looks like the -rel and -dbg strings are > magically respected by the right bots? If so, lgtm :) It is confusing, but to see how it works look at the slave steps stdio: E.g. http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%... Do a find in there for android_bot_id. That will show you the bot id for that bot. That comes from master.cfg. I think if main-tests-dbg doesn't match main-tests-rel it will match main-test-rel, but I'm making sure with he try jobs.
> I think if main-tests-dbg doesn't match main-tests-rel it will match > main-test-rel, but I'm making sure with he try jobs. That should read: I think if main-tests-dbg doesn't match main-tests-rel it will match *main-tests* (i.e. the matching prefix). I may need to have a main-tests-dbg and main-tests-rel.
On 2014/04/29 16:58:06, navabi wrote: > > I think if main-tests-dbg doesn't match main-tests-rel it will match > > main-test-rel, but I'm making sure with he try jobs. > > That should read: I think if main-tests-dbg doesn't match main-tests-rel it will > match *main-tests* (i.e. the matching prefix). > I may need to have a main-tests-dbg and main-tests-rel. Note that android_rel_triggered_tests runs telemetry_perf_unittests and android_dbg_triggered_tests does not. Checking Commit box.
The CQ bit was checked by navabi@google.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/250843008/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium
The CQ bit was checked by tonyg@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/250843008/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium
The CQ bit was checked by tonyg@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/250843008/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
Yaron, would you mind providing an owner stamp here?
rs lgtm navabi: you should be an OWNER
The CQ bit was checked by tonyg@chromium.org
On 2014/04/30 01:18:44, Yaron wrote:
> rs lgtm
>
> navabi: you should be an OWNER
He's in the file. I'm confused why the presubmit complained.
** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
build/android/buildbot/bb_run_bot.py
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/250843008/20001
On 2014/04/30 01:22:30, tonyg wrote: > On 2014/04/30 01:18:44, Yaron wrote: > > rs lgtm > > > > navabi: you should be an OWNER > > He's in the file. I'm confused why the presubmit complained. > > ** Presubmit ERRORS ** > Missing LGTM from an OWNER for these files: > build/android/buildbot/bb_run_bot.py It's because I am with my chromium account but not my google account. I think the OWNERS file here should have both our chromium and google accounts. That's what we have for infra repos. Anyway, I could have LGTM'd this myself with my chromium account.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium
The CQ bit was checked by tonyg@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/250843008/20001
Message was sent while issue was closed.
Change committed as 267166 |
