Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Issue 2508413002: DevTools: fix npm test debugging when using user compiled content shell (Closed)

Created:
4 years, 1 month ago by chenwilliam
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix npm test debugging when using user compiled content shell Previously, I wasn't copying the metadata files when the user compiled their own content shell, which is needed for debugging tests. Also, I've removed the test-only and build-only flags since we no longer need to copy/build devtools now that we're using --custom-devtools-frontend. BUG=654486 Committed: https://crrev.com/801aea9fbc24ef5486f799922aa0a7e1c583f8be Cr-Commit-Position: refs/heads/master@{#433279}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -24 lines) Patch
M third_party/WebKit/Source/devtools/package.json View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/readme.md View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/npm_test.js View 6 chunks +13 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
chenwilliam
PTAL, thanks.
4 years, 1 month ago (2016-11-18 01:10:14 UTC) #2
dgozman
lgtm. Thanks!
4 years, 1 month ago (2016-11-18 18:08:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508413002/1
4 years, 1 month ago (2016-11-18 18:16:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 20:12:58 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 20:18:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/801aea9fbc24ef5486f799922aa0a7e1c583f8be
Cr-Commit-Position: refs/heads/master@{#433279}

Powered by Google App Engine
This is Rietveld 408576698