Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 25084003: Make sure we clear registerProtocolHandler settings on page navigation. (Closed)

Created:
7 years, 2 months ago by Greg Billock
Modified:
7 years, 2 months ago
CC:
chromium-reviews, markusheintz_
Visibility:
Public.

Description

Make sure we clear registerProtocolHandler settings on page navigation. BUG=298198 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226360

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/content_settings/tab_specific_content_settings.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Greg Billock
Simple fix for this problem: have a look.
7 years, 2 months ago (2013-09-27 22:55:42 UTC) #1
Bernhard Bauer
LGTM!
7 years, 2 months ago (2013-09-28 08:44:14 UTC) #2
benwells
lgtm
7 years, 2 months ago (2013-09-30 01:24:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/25084003/1
7 years, 2 months ago (2013-09-30 16:05:40 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-09-30 23:13:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/25084003/26001
7 years, 2 months ago (2013-10-01 16:50:15 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-10-02 00:21:22 UTC) #7
Message was sent while issue was closed.
Change committed as 226360

Powered by Google App Engine
This is Rietveld 408576698