Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1177)

Issue 2508343002: Rename UnlinkedConst -> UnlinkedExpr (Closed)

Created:
4 years, 1 month ago by Paul Berry
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename UnlinkedConst -> UnlinkedExpr This is purely a nomenclature change to avoid confusion, since these data structures are used for all expressions that appear in summaries, regardless of whether they are const. R=scheglov@google.com, sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/f670a464d87f05ea9bed6703541463f30aeba08a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2026 lines, -2029 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 5 chunks +8 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.dart View 52 chunks +494 lines, -494 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.fbs View 29 chunks +248 lines, -249 lines 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 9 chunks +635 lines, -636 lines 0 comments Download
M pkg/analyzer/lib/src/summary/link.dart View 12 chunks +92 lines, -92 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 9 chunks +60 lines, -60 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_const_expr.dart View 19 chunks +77 lines, -76 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 176 chunks +407 lines, -409 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Paul Berry
4 years, 1 month ago (2016-11-17 22:18:56 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 1 month ago (2016-11-17 22:34:11 UTC) #4
scheglov
LGTM
4 years, 1 month ago (2016-11-17 23:19:31 UTC) #5
Paul Berry
4 years, 1 month ago (2016-11-17 23:27:53 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f670a464d87f05ea9bed6703541463f30aeba08a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698