Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: syzygy/agent/asan/page_protection_helpers_unittest.cc

Issue 2508333002: Remove the is_nested bit from the BlockInfo structure. (Closed)
Patch Set: Address Siggi's comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « syzygy/agent/asan/heaps/zebra_block_heap_unittest.cc ('k') | syzygy/agent/asan/runtime.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: syzygy/agent/asan/page_protection_helpers_unittest.cc
diff --git a/syzygy/agent/asan/page_protection_helpers_unittest.cc b/syzygy/agent/asan/page_protection_helpers_unittest.cc
index 226443cba7d2f6763eda644f035652a832cde618..0811f81dd9fa62ddaa29a159afbe248f10e06c12 100644
--- a/syzygy/agent/asan/page_protection_helpers_unittest.cc
+++ b/syzygy/agent/asan/page_protection_helpers_unittest.cc
@@ -176,7 +176,7 @@ class PageProtectionHelpersTest : public testing::OnExceptionCallbackTest {
::VirtualAlloc(NULL, layout.block_size, MEM_COMMIT, PAGE_READWRITE);
ASSERT_TRUE(alloc != NULL);
BlockInfo block_info = {};
- BlockInitialize(layout, alloc, false, &block_info);
+ BlockInitialize(layout, alloc, &block_info);
// By default the protections should be disabled for a fresh allocation.
EXPECT_NO_FATAL_FAILURE(
@@ -217,7 +217,7 @@ TEST_F(PageProtectionHelpersTest, GetBlockInfo) {
// Initialize the block in both memory and the shadow memory.
BlockInfo info = {};
- BlockInitialize(layout, alloc, false, &info);
+ BlockInitialize(layout, alloc, &info);
shadow_.PoisonAllocatedBlock(info);
// Try recovering in the usual case.
@@ -279,7 +279,7 @@ TEST_F(PageProtectionHelpersTest, BlockProtectAuto) {
ASSERT_TRUE(alloc != NULL);
BlockInfo block_info = {};
- BlockInitialize(layout, alloc, false, &block_info);
+ BlockInitialize(layout, alloc, &block_info);
TestAccessUnderProtection(block_info, kProtectNone);
block_info.header->state = ALLOCATED_BLOCK;
« no previous file with comments | « syzygy/agent/asan/heaps/zebra_block_heap_unittest.cc ('k') | syzygy/agent/asan/runtime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698