Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: syzygy/agent/asan/heaps/large_block_heap_unittest.cc

Issue 2508333002: Remove the is_nested bit from the BlockInfo structure. (Closed)
Patch Set: Address Siggi's comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: syzygy/agent/asan/heaps/large_block_heap_unittest.cc
diff --git a/syzygy/agent/asan/heaps/large_block_heap_unittest.cc b/syzygy/agent/asan/heaps/large_block_heap_unittest.cc
index 899569a56a098a001824572d1da7000594d2aeba..ab427705e768a9e6d981ee998390d17122d4bd47 100644
--- a/syzygy/agent/asan/heaps/large_block_heap_unittest.cc
+++ b/syzygy/agent/asan/heaps/large_block_heap_unittest.cc
@@ -70,7 +70,7 @@ TEST(LargeBlockHeapTest, EndToEnd) {
// definition.
void* alloc = h.AllocateBlock(0, 0, 0, &layout);
EXPECT_EQ(1u, h.size());
- BlockInitialize(layout, alloc, false, &block);
+ BlockInitialize(layout, alloc, &block);
EXPECT_TRUE(h.FreeBlock(block));
EXPECT_EQ(0u, h.size());
@@ -84,7 +84,7 @@ TEST(LargeBlockHeapTest, EndToEnd) {
EXPECT_LE(GetPageSize(), layout.header_size + layout.header_padding_size);
EXPECT_EQ(i, layout.body_size);
EXPECT_LE(GetPageSize(), layout.trailer_padding_size + layout.trailer_size);
- BlockInitialize(layout, alloc, false, &block);
+ BlockInitialize(layout, alloc, &block);
blocks.insert(block);
}
@@ -111,12 +111,12 @@ TEST(LargeBlockHeapTest, ZeroSizedAllocationsHaveDistinctAddresses) {
BlockInfo b1 = {};
a1 = h.AllocateBlock(0, 0, 0, &layout);
EXPECT_TRUE(a1 != NULL);
- BlockInitialize(layout, a1, false, &b1);
+ BlockInitialize(layout, a1, &b1);
BlockInfo b2 = {};
a2 = h.AllocateBlock(0, 0, 0, &layout);
EXPECT_TRUE(a2 != NULL);
- BlockInitialize(layout, a2, false, &b2);
+ BlockInitialize(layout, a2, &b2);
EXPECT_NE(a1, a2);
EXPECT_NE(b1.header, b2.header);
« no previous file with comments | « syzygy/agent/asan/heap_managers/block_heap_manager.cc ('k') | syzygy/agent/asan/heaps/simple_block_heap_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698