Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1767)

Unified Diff: syzygy/agent/asan/error_info_unittest.cc

Issue 2508333002: Remove the is_nested bit from the BlockInfo structure. (Closed)
Patch Set: Address Siggi's comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « syzygy/agent/asan/block_unittest.cc ('k') | syzygy/agent/asan/heap_checker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: syzygy/agent/asan/error_info_unittest.cc
diff --git a/syzygy/agent/asan/error_info_unittest.cc b/syzygy/agent/asan/error_info_unittest.cc
index 8145391049fc1e55a796a665b524c974e58abe5d..67cabf7ce87954c4e846b34d11b72cebeda8b50c 100644
--- a/syzygy/agent/asan/error_info_unittest.cc
+++ b/syzygy/agent/asan/error_info_unittest.cc
@@ -53,7 +53,7 @@ class AsanErrorInfoTest : public testing::TestWithAsanRuntime {
BlockPlanLayout(kShadowRatio, kShadowRatio, 8, 0, 0, &layout);
dummy_block_data_.resize(layout.block_size);
BlockInfo info = {};
- BlockInitialize(layout, &dummy_block_data_.at(0), false, &info);
+ BlockInitialize(layout, &dummy_block_data_.at(0), &info);
runtime_->shadow()->PoisonAllocatedBlock(info);
// Normalize a handful of fields to make the comparison simpler.
@@ -156,8 +156,8 @@ TEST_F(AsanErrorInfoTest, GetBadAccessInformationNestedBlock) {
0,
&inner_block_layout));
BlockInfo inner_block_info = {};
- BlockInitialize(inner_block_layout, fake_block.block_info.body, true,
- &inner_block_info);
+ BlockInitialize(inner_block_layout, fake_block.block_info.body,
+ &inner_block_info);
ASSERT_NE(reinterpret_cast<void*>(NULL), inner_block_info.body);
runtime_->shadow()->PoisonAllocatedBlock(inner_block_info);
inner_block_info.header->alloc_stack =
« no previous file with comments | « syzygy/agent/asan/block_unittest.cc ('k') | syzygy/agent/asan/heap_checker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698