Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2508323003: Roll clang 284979:287226. (Closed)

Created:
4 years, 1 month ago by hans
Modified:
4 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, Lei Zhang, dsinclair, yunlian, glider+clang_chromium.org, Nico, ukai+watch_chromium.org, Reid Kleckner, hans, dmikurube+clang_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll clang 284979:287226. Ran `tools/clang/scripts/upload_revision.py 287226`. BUG=665063 Committed: https://crrev.com/9b87c91ac267d38736890d2b63e6e56a893ccbbb Cr-Commit-Position: refs/heads/master@{#433124}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/clang/scripts/update.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
hans
Please take a look.
4 years, 1 month ago (2016-11-18 00:47:35 UTC) #4
Nico
lgtm
4 years, 1 month ago (2016-11-18 03:39:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508323003/1
4 years, 1 month ago (2016-11-18 04:20:49 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 05:51:06 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9b87c91ac267d38736890d2b63e6e56a893ccbbb Cr-Commit-Position: refs/heads/master@{#433124}
4 years, 1 month ago (2016-11-18 05:53:08 UTC) #12
Nico
4 years, 1 month ago (2016-11-18 17:39:25 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2520453002/ by thakis@chromium.org.

The reason for reverting is: Makes every link on Mac warn

clang: warning: libLTO.dylib relative to clang installed dir not found; using
'ld' default search path instead [-Wliblto]

Probably due to https://reviews.llvm.org/D25932. We need to talk to Mehdi and
come up with a plan. Also, it's lame that that warning isn't affected by
-Werror, else the bots would've caught this..

Powered by Google App Engine
This is Rietveld 408576698