Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2508273002:
[Media Router] Center device missing text. (Closed)
|
Created:
4 years, 1 month ago by apacible Modified:
4 years, 1 month ago Reviewers:
imcheng CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Media Router] Center device missing text.
See crbug for before screenshot.
BUG=665301
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/ae0a80ba03e4a51253be34dfea8497753e6188f0
Cr-Commit-Position: refs/heads/master@{#433055}
Patch Set 1 #
Messages
Total messages: 22 (15 generated)
Description was changed from ========== device missing text BUG= ========== to ========== device missing text BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by apacible@chromium.org to run a CQ dry run
Description was changed from ========== device missing text BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [Media Router] Fix device missing text. See crbug for before screenshot. BUG=665301 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
apacible@chromium.org changed reviewers: + imcheng@chromium.org
Description was changed from ========== [Media Router] Fix device missing text. See crbug for before screenshot. BUG=665301 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [Media Router] Center device missing text. See crbug for before screenshot. BUG=665301 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAL, thanks! https://screenshot.googleplex.com/cshKuQgMXqB.png
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by apacible@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply the patch.
The CQ bit was checked by apacible@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Media Router] Center device missing text. See crbug for before screenshot. BUG=665301 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [Media Router] Center device missing text. See crbug for before screenshot. BUG=665301 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [Media Router] Center device missing text. See crbug for before screenshot. BUG=665301 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [Media Router] Center device missing text. See crbug for before screenshot. BUG=665301 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/ae0a80ba03e4a51253be34dfea8497753e6188f0 Cr-Commit-Position: refs/heads/master@{#433055} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ae0a80ba03e4a51253be34dfea8497753e6188f0 Cr-Commit-Position: refs/heads/master@{#433055}
Message was sent while issue was closed.
Description was changed from ========== [Media Router] Center device missing text. See crbug for before screenshot. BUG=665301 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/ae0a80ba03e4a51253be34dfea8497753e6188f0 Cr-Commit-Position: refs/heads/master@{#433055} ========== to ========== [Media Router] Center device missing text. See crbug for before screenshot. BUG=665301 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/ae0a80ba03e4a51253be34dfea8497753e6188f0 Cr-Commit-Position: refs/heads/master@{#433055} ==========
Message was sent while issue was closed.
apacible@chromium.org changed reviewers: - apacible@google.com |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
