[sync] skeleton implementation of AutocompleteSyncBridge

components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.

[maxbogue, 2016/11/18 22:22:35]

line below

[Patrick Noland, 2016/11/22 18:51:04]

Done.

+#include "components/autofill/core/browser/webdata/autocomplete_sync_bridge.h"
+
+#include "base/bind.h"
+#include "base/memory/ptr_util.h"
+#include "components/autofill/core/browser/webdata/autofill_table.h"
+#include "components/autofill/core/browser/webdata/autofill_webdata_backend.h"
+#include "components/autofill/core/browser/webdata/autofill_webdata_service.h"
+#include "components/sync/model/entity_data.h"
+#include "components/sync/model/model_type_change_processor.h"
+#include "components/sync/model/sync_error.h"
+#include "components/sync/model_impl/accumulating_metadata_change_list.h"
+

[maxbogue, 2016/11/18 22:22:35]

no blank line; it's all one section.

[Patrick Noland, 2016/11/22 18:51:04]

Done.

+#include "net/base/escape.h"
+
+namespace {

[maxbogue, 2016/11/18 22:22:35]

Add line below.

[Patrick Noland, 2016/11/22 18:51:04]

Done.

+void* UserDataKey() {
+  // Use the address of a static that COMDAT folding won't ever collide
+  // with something else.
+  static int user_data_key = 0;
+  return reinterpret_cast<void*>(&user_data_key);
+}
+
+const std::string FormatStorageKey(const std::string name,
+                                   const std::string value) {
+  return net::EscapePath(name) + "|" + net::EscapePath(value);
+}
+}  // namespace

[maxbogue, 2016/11/18 22:22:35]

Add line above.

[Patrick Noland, 2016/11/22 18:51:04]

Done.

+
+namespace autofill {
+
+const char kAutocompleteEntryNamespaceTag[] = "autofill_entry|";

[maxbogue, 2016/11/18 22:22:35]

The whole anonymous namespace can be inside the autofill namespace and can
include this constant.

[Patrick Noland, 2016/11/22 18:51:04]

Done.

+
+// static
+void AutocompleteSyncBridge::CreateForWebDataServiceAndBackend(
+    AutofillWebDataService* web_data_service,
+    AutofillWebDataBackend* web_data_backend) {
+  web_data_service->GetDBUserData()->SetUserData(
+      UserDataKey(),
+      new AutocompleteSyncBridge(
+          web_data_backend,
+          base::Bind(&syncer::ModelTypeChangeProcessor::Create)));
+}
+
+// static
+AutocompleteSyncBridge* AutocompleteSyncBridge::FromWebDataService(
+    AutofillWebDataService* web_data_service) {
+  return static_cast<AutocompleteSyncBridge*>(
+      web_data_service->GetDBUserData()->GetUserData(UserDataKey()));
+}
+
+AutocompleteSyncBridge::AutocompleteSyncBridge(
+    AutofillWebDataBackend* backend,
+    const ChangeProcessorFactory& change_processor_factory)
+    : ModelTypeSyncBridge(change_processor_factory, syncer::AUTOFILL),
+      web_data_backend_(backend),
+      scoped_observer_(this) {
+  DCHECK(web_data_backend_);
+
+  scoped_observer_.Add(web_data_backend_);
+}
+
+AutocompleteSyncBridge::~AutocompleteSyncBridge() {
+  DCHECK(CalledOnValidThread());
+}
+
+// syncer::ModelTypeService implementation.
+std::unique_ptr<syncer::MetadataChangeList>
+AutocompleteSyncBridge::CreateMetadataChangeList() {
+  NOTIMPLEMENTED();
+  return base::MakeUnique<syncer::AccumulatingMetadataChangeList>();

[maxbogue, 2016/11/18 22:22:36]

You want to make your own subclass of InMemoryMetadataChangeList; AMCL is for
ModelTypeStore users specifically, which is why it is in model_impl (which you
shouldn't be including from). You can leave that for another CL and just return
nullptr here.

[Patrick Noland, 2016/11/22 18:51:04]

Done.

+}
+
+syncer::SyncError AutocompleteSyncBridge::MergeSyncData(
+    std::unique_ptr<syncer::MetadataChangeList> metadata_change_list,
+    syncer::EntityDataMap entity_data_map) {
+  DCHECK(CalledOnValidThread());
+  NOTIMPLEMENTED();
+  return syncer::SyncError();
+}
+
+syncer::SyncError AutocompleteSyncBridge::ApplySyncChanges(
+    std::unique_ptr<syncer::MetadataChangeList> metadata_change_list,
+    syncer::EntityChangeList entity_changes) {
+  NOTIMPLEMENTED();
+  return syncer::SyncError();
+}
+void AutocompleteSyncBridge::AutocompleteSyncBridge::GetData(
+    StorageKeyList storage_keys,
+    DataCallback callback) {
+  NOTIMPLEMENTED();
+}
+
+void AutocompleteSyncBridge::GetAllData(DataCallback callback) {
+  NOTIMPLEMENTED();
+}
+
+std::string AutocompleteSyncBridge::GetClientTag(
+    const syncer::EntityData& entity_data) {
+  DCHECK(entity_data.specifics.has_autofill());
+
+  const sync_pb::AutofillSpecifics specifics = entity_data.specifics.autofill();
+  std::string storage_key =
+      FormatStorageKey(specifics.name(), specifics.value());
+  return KeyToTag(storage_key);

[pavely, 2016/11/21 22:54:19]

KeyToTag is just prepending storage_key with prefix. I would simply do it here
inline.

[Patrick Noland, 2016/11/22 18:51:04]

Done.

+}
+
+std::string AutocompleteSyncBridge::GetStorageKey(
+    const syncer::EntityData& entity_data) {
+  DCHECK(entity_data.specifics.has_autofill());
+
+  const sync_pb::AutofillSpecifics specifics = entity_data.specifics.autofill();
+  return FormatStorageKey(specifics.name(), specifics.value());
+}
+
+syncer::ConflictResolution AutocompleteSyncBridge::ResolveConflict(

[maxbogue, 2016/11/18 22:22:35]

This one is optional to override and should probably be omitted unless you know
we're gonna want a custom implementation.

[Patrick Noland, 2016/11/22 18:51:04]

Done.

+    const syncer::EntityData& local_data,
+    const syncer::EntityData& remote_data) const {
+  return syncer::ConflictResolution::UseLocal();
+}
+
+// AutofillWebDataServiceObserverOnDBThread implementation.
+void AutocompleteSyncBridge::AutofillEntriesChanged(
+    const AutofillChangeList& changes) {}
+
+// static
+std::string AutocompleteSyncBridge::KeyToTag(std::string storage_key) {

[pavely, 2016/11/21 22:54:19]

Could you pass parameter as const std::string&.

[Patrick Noland, 2016/11/22 18:51:04]

Not necessary since I'm removing KeyToTag entirely.

+  std::string prefix(kAutocompleteEntryNamespaceTag);
+  return prefix + storage_key;
+}
+
+}  // namespace autofill