Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2508253002: VM: Fix sticky matching for anchored regexps on interpreter. (Closed)

Created:
4 years, 1 month ago by Vyacheslav Egorov (Google)
Modified:
4 years, 1 month ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Fix sticky matching for anchored regexps on interpreter. It was fixed in CompileIR but not ported to CompileBytecode. TBR=rmacnak@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/ce25ab3aa050d0e53207cf36814bb36eb70300ca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/vm/regexp.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Vyacheslav Egorov (Google)
4 years, 1 month ago (2016-11-17 19:02:16 UTC) #1
Vyacheslav Egorov (Google)
Committed patchset #1 (id:1) manually as ce25ab3aa050d0e53207cf36814bb36eb70300ca (presubmit successful).
4 years, 1 month ago (2016-11-17 19:04:16 UTC) #3
rmacnak
4 years, 1 month ago (2016-11-18 17:15:13 UTC) #4
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698