Enabled ink drop highlight for focus on bookmark bar buttons.

chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
index 28fb2baf8263f1b6d6fa14299e4e6ade6d4d6cd8..361c0a90a5eab2b270127cf475608aa5d6412326 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
@@ -217,7 +217,10 @@ class BookmarkButtonBase : public views::LabelButton {
 
   // LabelButton:
   std::unique_ptr<views::InkDrop> CreateInkDrop() override {
-    return CreateDefaultFloodFillInkDropImpl();
+    std::unique_ptr<views::InkDropImpl> ink_drop =
+        CreateDefaultFloodFillInkDropImpl();
+    ink_drop->SetShowHighlightOnFocus(true);

[Peter Kasting, 2016/11/17 19:31:57]

Should CreateDefaultFloodFillInkDropImpl() do this by default?  Should it take
an arg as to whether the created ink drop should show highlight on focus, so
callers have to explicitly choose?

[bruthig, 2016/11/17 19:43:33]

At a high level there is a lot of rework opportunities with how the InkDrop
parts are constructed.  I'm hoping to replace the virtual CreateInkDrop*()
functions in InkDropHost/InkDropHostView with a factory design pattern. This
will hopefully make it more obvious/explicit/etc to clients as to how the ink
drop is configured.

With respect to the specific request tho, UI elements that use the ink drop
highlight to show keyboard focus are quite special and there are really only 2
or 3 surfaces that do it, namely toolbar buttons and bookmark bar buttons.  I
wouldn't want to over burden all the other elements with an extra param for such
a special case.

I plan to leave it as is unless you have strong objections.

+    return std::move(ink_drop);
   }
 
   std::unique_ptr<views::InkDropRipple> CreateInkDropRipple() const override {
@@ -337,7 +340,10 @@ class BookmarkMenuButtonBase : public views::MenuButton {
 
   // MenuButton:
   std::unique_ptr<views::InkDrop> CreateInkDrop() override {
-    return CreateDefaultFloodFillInkDropImpl();
+    std::unique_ptr<views::InkDropImpl> ink_drop =
+        CreateDefaultFloodFillInkDropImpl();
+    ink_drop->SetShowHighlightOnFocus(true);
+    return std::move(ink_drop);
   }
 
   std::unique_ptr<views::InkDropRipple> CreateInkDropRipple() const override {