Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2508233002: Don't set sequential focus for offscreen nodes (Closed)

Created:
4 years, 1 month ago by David Tseng
Modified:
4 years, 1 month ago
Reviewers:
dmazzoni
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't set sequential focus for offscreen nodes This is yet another case where sequential focus causes focus stealing. https://www.sitepoint.com/html5-geolocation/ and the ad frame is an example. Setting sequential focus on the offscreen static text "ad closed by " causes focus to jump to the root and navigation gets stuck forever. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/ac734e21bee1501562f12fc6c053a15294f1e29f Cr-Commit-Position: refs/heads/master@{#433023}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
David Tseng
4 years, 1 month ago (2016-11-17 18:30:55 UTC) #3
dmazzoni
lgtm
4 years, 1 month ago (2016-11-17 18:50:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508233002/1
4 years, 1 month ago (2016-11-17 20:49:00 UTC) #6
commit-bot: I haz the power
Failed to apply the patch.
4 years, 1 month ago (2016-11-18 00:45:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508233002/1
4 years, 1 month ago (2016-11-18 00:51:38 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 02:47:12 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 02:50:51 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac734e21bee1501562f12fc6c053a15294f1e29f
Cr-Commit-Position: refs/heads/master@{#433023}

Powered by Google App Engine
This is Rietveld 408576698