Add GN build file for ui/base target.

Add GN build file for ui/base target.

In Debug config:

$ gn gen out/Debug_gn

$ ninja -C out/Debug_gn ui_base

In Release config:

$ gn gen out/Release_gn --args='is_debug=false'

$ ninja -C out/Release_gn ui_base

BUG=None
TEST=see above
R=brettw@chromium.org
TBR=ben

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266836

[tfarina, 2014-04-28 06:29:38]

All green! Should be good to go.

ptal.

[brettw, 2014-04-28 17:31:26]

Sweet! LGTM

https://codereview.chromium.org/250823008/diff/20001/ui/base/BUILD.gn
File ui/base/BUILD.gn (right):

https://codereview.chromium.org/250823008/diff/20001/ui/base/BUILD.gn#newcode11
ui/base/BUILD.gn:11: component("ui_base") {
Can you call this "base" and rename to "ui_base" in the output name?

https://codereview.chromium.org/250823008/diff/20001/ui/base/BUILD.gn#newcode386
ui/base/BUILD.gn:386: "../..",
You don't need this (the default config adds the root build dir for you).

https://codereview.chromium.org/250823008/diff/20001/ui/base/BUILD.gn#newcode387
ui/base/BUILD.gn:387: "../../third_party/wtl/include",
Delete this and add a dependency on "//third_party/wtl".

https://codereview.chromium.org/250823008/diff/20001/ui/base/BUILD.gn#newcode397
ui/base/BUILD.gn:397: #'d2d1.dll',
Convert these to:
  ldflags = [
    "/DELAYLOAD:d2d1.dll",
    ...
  ]

https://codereview.chromium.org/250823008/diff/20001/ui/base/BUILD.gn#newcode402
ui/base/BUILD.gn:402: #'d2d1.lib',
Can you add these + the "libraries" below to the "libs" variable?

https://codereview.chromium.org/250823008/diff/20001/ui/base/BUILD.gn#newcode438
ui/base/BUILD.gn:438:
#'$(SDKROOT)/System/Library/Frameworks/Accelerate.framework',
libs += [ "Accelerate.framework", "AudioUnit.framework", "CoreVideo.framework" ]
(I just added this to the cookbook).

https://codereview.chromium.org/250823008/diff/20001/ui/base/BUILD.gn#newcode493
ui/base/BUILD.gn:493: #TODO(tfarina): port this component to GN.
For stuff unported, I've geen doing TODO(GYP) so we can tell what needs to be
done for GYP conversion by grepping (as opposed to various build TODOs unrelated
to GYP conversion). Check for other ones.

https://codereview.chromium.org/250823008/diff/20001/ui/base/BUILD.gn#newcode518
ui/base/BUILD.gn:518: #'-ldl',
Delete this, "dl" is added by default in the shared build setup. For future
reference, normally this would get converted to
  libs = [ "dl" ]

https://codereview.chromium.org/250823008/diff/20001/ui/base/BUILD.gn#newcode522
ui/base/BUILD.gn:522: #if (use_system_icu) {
TODO(GYP)

[tfarina, 2014-04-29 03:47:47]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2014-04-29 03:48:06]

https://codereview.chromium.org/250823008/diff/20001/ui/base/BUILD.gn
File ui/base/BUILD.gn (right):

https://codereview.chromium.org/250823008/diff/20001/ui/base/BUILD.gn#newcode11
ui/base/BUILD.gn:11: component("ui_base") {
On 2014/04/28 17:31:26, brettw wrote:
> Can you call this "base" and rename to "ui_base" in the output name?
Brett, I know this is nice to have, but it is not possible at this moment:

$ cd out/Release_gn
$ ninja base
ninja: error: unknown target 'base', did you mean 'balsa'?

$ ninja ui_base
ninja: error: unknown target 'ui_base', did you mean 'quic_base'?

I suggest not doing this in more and more targets until we have a reliable way
to uniquify the names of the targets.

I think we should wait until we could say:

ninja //ui/base:ui_base

Like in blaze you do:

blaze build //base:strings

https://codereview.chromium.org/250823008/diff/20001/ui/base/BUILD.gn#newcode386
ui/base/BUILD.gn:386: "../..",
On 2014/04/28 17:31:26, brettw wrote:
> You don't need this (the default config adds the root build dir for you).

Done.

https://codereview.chromium.org/250823008/diff/20001/ui/base/BUILD.gn#newcode387
ui/base/BUILD.gn:387: "../../third_party/wtl/include",
On 2014/04/28 17:31:26, brettw wrote:
> Delete this and add a dependency on "//third_party/wtl".

Done.

https://codereview.chromium.org/250823008/diff/20001/ui/base/BUILD.gn#newcode397
ui/base/BUILD.gn:397: #'d2d1.dll',
On 2014/04/28 17:31:26, brettw wrote:
> Convert these to:
>   ldflags = [
>     "/DELAYLOAD:d2d1.dll",
>     ...
>   ]

Done.

https://codereview.chromium.org/250823008/diff/20001/ui/base/BUILD.gn#newcode402
ui/base/BUILD.gn:402: #'d2d1.lib',
On 2014/04/28 17:31:26, brettw wrote:
> Can you add these + the "libraries" below to the "libs" variable?

Done.

https://codereview.chromium.org/250823008/diff/20001/ui/base/BUILD.gn#newcode438
ui/base/BUILD.gn:438:
#'$(SDKROOT)/System/Library/Frameworks/Accelerate.framework',
On 2014/04/28 17:31:26, brettw wrote:
> libs += [ "Accelerate.framework", "AudioUnit.framework", "CoreVideo.framework"
]
> (I just added this to the cookbook).

Done.

https://codereview.chromium.org/250823008/diff/20001/ui/base/BUILD.gn#newcode493
ui/base/BUILD.gn:493: #TODO(tfarina): port this component to GN.
On 2014/04/28 17:31:26, brettw wrote:
> For stuff unported, I've geen doing TODO(GYP) so we can tell what needs to be
> done for GYP conversion by grepping (as opposed to various build TODOs
unrelated
> to GYP conversion). Check for other ones.

Done.

https://codereview.chromium.org/250823008/diff/20001/ui/base/BUILD.gn#newcode518
ui/base/BUILD.gn:518: #'-ldl',
On 2014/04/28 17:31:26, brettw wrote:
> Delete this, "dl" is added by default in the shared build setup. For future
> reference, normally this would get converted to
>   libs = [ "dl" ]

Done.

https://codereview.chromium.org/250823008/diff/20001/ui/base/BUILD.gn#newcode522
ui/base/BUILD.gn:522: #if (use_system_icu) {
On 2014/04/28 17:31:26, brettw wrote:
> TODO(GYP)

Done.

[commit-bot: I haz the power, 2014-04-29 03:48:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/250823008/40001

[commit-bot: I haz the power, 2014-04-29 10:51:24]

Change committed as 266836

[Ruud van Asseldonk, 2015-09-24 16:17:01]

https://codereview.chromium.org/250823008/diff/40001/ui/base/BUILD.gn
File ui/base/BUILD.gn (right):

https://codereview.chromium.org/250823008/diff/40001/ui/base/BUILD.gn#newcode346
ui/base/BUILD.gn:346: if ((is_linux && !is_chromeos) || is_chromeos) {
This is logically equivalent to (is_linux || is_chromeos).

A   B   ((A && !B) || B)   (A || B)
0   0                  0          0
0   1                  1          1
1   0                  1          1
1   1                  1          1

Could this be a bug?

[Dirk Pranke, 2015-09-24 18:32:15]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2015-09-24 18:32:15]

https://codereview.chromium.org/250823008/diff/40001/ui/base/BUILD.gn
File ui/base/BUILD.gn (right):

https://codereview.chromium.org/250823008/diff/40001/ui/base/BUILD.gn#newcode346
ui/base/BUILD.gn:346: if ((is_linux && !is_chromeos) || is_chromeos) {
On 2015/09/24 16:17:00, Ruud van Asseldonk wrote:
> This is logically equivalent to (is_linux || is_chromeos).
> 
> A   B   ((A && !B) || B)   (A || B)
> 0   0                  0          0
> 0   1                  1          1
> 1   0                  1          1
> 1   1                  1          1
> 
> Could this be a bug?

I'm not sure what the intent here is, but since is_chromeos implies
is_linux, this is really just saying if (is_linux) :).

Feel free to file a bug and get one of the file owners to look at it.