Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issue 2508223004: Fix for Import/ExportDirective annotations while applying resynthesized element model. (Closed)

Created:
4 years, 1 month ago by scheglov
Modified:
4 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for Import/ExportDirective annotations while applying resynthesized element model. This takea care of the Pub analysis crash you saw. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/4f1fa54e341dfea8afa7f49078b0361797cf8f6c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -4 lines) Patch
M pkg/analyzer/lib/src/generated/declaration_resolver.dart View 2 chunks +22 lines, -4 lines 0 comments Download
M pkg/analyzer/test/generated/declaration_resolver_test.dart View 2 chunks +54 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 1 month ago (2016-11-18 22:46:33 UTC) #1
Brian Wilkerson
lgtm
4 years, 1 month ago (2016-11-18 23:05:21 UTC) #2
scheglov
4 years, 1 month ago (2016-11-18 23:06:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4f1fa54e341dfea8afa7f49078b0361797cf8f6c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698