Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2508213002: [OfflinePages] Fix Coordinator issue with lagging NetworkChangeNotifier (Closed)

Created:
4 years, 1 month ago by dougarnett
Modified:
4 years, 1 month ago
Reviewers:
Pete Williamson
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[OfflinePages] Fix Coordinator issue with lagging NetworkChangeNotifier Use current device conditions in TryNextRequest to decide if have network connection currently since NetworkChangeNofifier might not be updated before GcmNetworkManager is and kicks StartProcessing. BUG=665551 Committed: https://crrev.com/ff642e8ff58fefd407c1af7e2f74284c00d65d5f Cr-Commit-Position: refs/heads/master@{#432936}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -9 lines) Patch
M components/offline_pages/background/request_coordinator.h View 1 chunk +1 line, -1 line 0 comments Download
M components/offline_pages/background/request_coordinator.cc View 9 chunks +18 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
dougarnett
4 years, 1 month ago (2016-11-17 18:15:23 UTC) #4
Pete Williamson
lgtm
4 years, 1 month ago (2016-11-17 18:36:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508213002/1
4 years, 1 month ago (2016-11-17 18:38:53 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 19:46:35 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 20:28:52 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff642e8ff58fefd407c1af7e2f74284c00d65d5f
Cr-Commit-Position: refs/heads/master@{#432936}

Powered by Google App Engine
This is Rietveld 408576698