Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2508203007: Add a regression test for rasterizing PDFs. (Closed)

Created:
4 years, 1 month ago by Lei Zhang
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez, rbpotter
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Add back test PDF #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -0 lines) Patch
M fpdfsdk/fpdfedit_embeddertest.cpp View 1 3 chunks +82 lines, -0 lines 0 comments Download
A testing/resources/black.pdf View 2 Binary file 0 comments Download

Messages

Total messages: 20 (16 generated)
Lei Zhang
This copies a bunch of code from the bitmap printing path in the Chrome PDF ...
4 years, 1 month ago (2016-11-21 22:53:11 UTC) #12
Tom Sepez
lgtm
4 years, 1 month ago (2016-11-21 23:00:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508203007/40001
4 years, 1 month ago (2016-11-21 23:32:38 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 23:32:57 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/dc7ec035a6962b788e75f4beaa4cf8fbddd8...

Powered by Google App Engine
This is Rietveld 408576698