Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1588)

Unified Diff: cc/ipc/cc_param_traits_unittest.cc

Issue 2508203004: Add hints for potential overlay promotion on android. (Closed)
Patch Set: promotable_resources_ => promotable_resource_hints_ Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/ipc/cc_param_traits_unittest.cc
diff --git a/cc/ipc/cc_param_traits_unittest.cc b/cc/ipc/cc_param_traits_unittest.cc
index 1b663fdc2912b6c4f1f232eee820954fb7535f98..9c4cd8021a26f120c68b4f0757c9e0cc3f91f8bb 100644
--- a/cc/ipc/cc_param_traits_unittest.cc
+++ b/cc/ipc/cc_param_traits_unittest.cc
@@ -208,6 +208,7 @@ class CCParamTraitsTest : public testing::Test {
EXPECT_EQ(a.mailbox_holder.texture_target, b.mailbox_holder.texture_target);
EXPECT_EQ(a.mailbox_holder.sync_token, b.mailbox_holder.sync_token);
EXPECT_EQ(a.is_overlay_candidate, b.is_overlay_candidate);
+ EXPECT_EQ(a.is_backed_by_surface_texture, b.is_backed_by_surface_texture);
piman 2016/12/01 21:55:25 nit (here and below): also add wants_promotion_hin
liberato (no reviews please) 2016/12/05 18:14:00 Done.
}
};
@@ -571,6 +572,7 @@ TEST_F(CCParamTraitsTest, Resources) {
arbitrary_resource1.mailbox_holder.texture_target = GL_TEXTURE_2D;
arbitrary_resource1.mailbox_holder.sync_token = arbitrary_token1;
arbitrary_resource1.is_overlay_candidate = true;
+ arbitrary_resource1.is_backed_by_surface_texture = true;
TransferableResource arbitrary_resource2;
arbitrary_resource2.id = 789132;
@@ -581,6 +583,7 @@ TEST_F(CCParamTraitsTest, Resources) {
arbitrary_resource2.mailbox_holder.texture_target = GL_TEXTURE_EXTERNAL_OES;
arbitrary_resource2.mailbox_holder.sync_token = arbitrary_token2;
arbitrary_resource2.is_overlay_candidate = false;
+ arbitrary_resource2.is_backed_by_surface_texture = false;
std::unique_ptr<RenderPass> renderpass_in = RenderPass::Create();
renderpass_in->SetNew(RenderPassId(1, 1), gfx::Rect(), gfx::Rect(),

Powered by Google App Engine
This is Rietveld 408576698