Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Side by Side Diff: components/display_compositor/compositor_overlay_candidate_validator_android.h

Issue 2508203004: Add hints for potential overlay promotion on android. (Closed)
Patch Set: #include and comment cleanup Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_DISPLAY_COMPOSITOR_COMPOSITOR_OVERLAY_CANDIDATE_VALIDATOR_AND ROID_H_ 5 #ifndef COMPONENTS_DISPLAY_COMPOSITOR_COMPOSITOR_OVERLAY_CANDIDATE_VALIDATOR_AND ROID_H_
6 #define COMPONENTS_DISPLAY_COMPOSITOR_COMPOSITOR_OVERLAY_CANDIDATE_VALIDATOR_AND ROID_H_ 6 #define COMPONENTS_DISPLAY_COMPOSITOR_COMPOSITOR_OVERLAY_CANDIDATE_VALIDATOR_AND ROID_H_
7 7
8 #include <set>
9
8 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "cc/base/resource_id.h"
9 #include "components/display_compositor/compositor_overlay_candidate_validator.h " 12 #include "components/display_compositor/compositor_overlay_candidate_validator.h "
10 #include "components/display_compositor/display_compositor_export.h" 13 #include "components/display_compositor/display_compositor_export.h"
11 14
12 namespace display_compositor { 15 namespace display_compositor {
13 16
14 // An overlay validator for supporting fullscreen video underlays on Android. 17 // An overlay validator for supporting fullscreen video underlays on Android.
15 // Things are a bit different on Android compared with other platforms. By the 18 // Things are a bit different on Android compared with other platforms. By the
16 // time a video frame is marked as overlayable it means the video decoder was 19 // time a video frame is marked as overlayable it means the video decoder was
17 // outputting to a Surface that we can't read back from. As a result, the 20 // outputting to a Surface that we can't read back from. As a result, the
18 // overlay must always succeed, or the video won't be visible. This is one of of 21 // overlay must always succeed, or the video won't be visible. This is one of of
19 // the reasons that only fullscreen is supported: we have to be sure that 22 // the reasons that only fullscreen is supported: we have to be sure that
20 // nothing will cause the overlay to be rejected, because there's no fallback to 23 // nothing will cause the overlay to be rejected, because there's no fallback to
21 // gl compositing. 24 // gl compositing.
22 class DISPLAY_COMPOSITOR_EXPORT CompositorOverlayCandidateValidatorAndroid 25 class DISPLAY_COMPOSITOR_EXPORT CompositorOverlayCandidateValidatorAndroid
23 : public CompositorOverlayCandidateValidator { 26 : public CompositorOverlayCandidateValidator {
24 public: 27 public:
25 CompositorOverlayCandidateValidatorAndroid(); 28 CompositorOverlayCandidateValidatorAndroid();
26 ~CompositorOverlayCandidateValidatorAndroid() override; 29 ~CompositorOverlayCandidateValidatorAndroid() override;
27 30
28 void GetStrategies(cc::OverlayProcessor::StrategyList* strategies) override; 31 void GetStrategies(cc::OverlayProcessor::StrategyList* strategies) override;
29 void CheckOverlaySupport(cc::OverlayCandidateList* surfaces) override; 32 void CheckOverlaySupport(cc::OverlayCandidateList* surfaces) override;
30 bool AllowCALayerOverlays() override; 33 bool AllowCALayerOverlays() override;
31 34
32 void SetSoftwareMirrorMode(bool enabled) override; 35 void SetSoftwareMirrorMode(bool enabled) override;
33 36
37 void ClearPromotableResources() override;
38
39 bool IsResourcePromotable(cc::ResourceId resource_id) override;
40
34 private: 41 private:
42 std::set<cc::ResourceId> promotable_resources_;
43
35 DISALLOW_COPY_AND_ASSIGN(CompositorOverlayCandidateValidatorAndroid); 44 DISALLOW_COPY_AND_ASSIGN(CompositorOverlayCandidateValidatorAndroid);
36 }; 45 };
37 46
38 } // namespace display_compositor 47 } // namespace display_compositor
39 48
40 #endif // COMPONENTS_DISPLAY_COMPOSITOR_COMPOSITOR_OVERLAY_CANDIDATE_VALIDATOR_ ANDROID_H_ 49 #endif // COMPONENTS_DISPLAY_COMPOSITOR_COMPOSITOR_OVERLAY_CANDIDATE_VALIDATOR_ ANDROID_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698