Add hints for potential overlay promotion on android.

cc/output/gl_renderer.cc

 // Copyright 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/output/gl_renderer.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 2454 matching lines @@
              .egl_image_external);
 
   TexCoordPrecision tex_coord_precision = TexCoordPrecisionRequired(
       gl_, &highp_threshold_cache_, highp_threshold_min_,
       quad->shared_quad_state->visible_quad_layer_rect.bottom_right());
 
   const VideoStreamTextureProgram* program =
       GetVideoStreamTextureProgram(tex_coord_precision);
   SetUseProgram(program->program());
 
+  bool is_promotable = IsResourcePromotable(quad->resource_id());

[liberato (no reviews please), 2016/11/19 18:25:52]

this is where i picture sending the message to the GLStreamTextureImage via
gl_->SomeCustomCommandCHROMIUM().

i tried to encapsulate this inside the overlay logic also, but it was a little
weird having to lock the resource, send in the context, etc.   getting all of
the 'is / is not promotable' logic into the overlay processor seemed like the
key idea from our mtg, so i didn't worry too much about moving notification
elsewhere.

please let me know if you'd prefer this to be moved.

[piman, 2016/11/23 00:37:25]

I guess it feels a bit odd to do here...
How about:
- ResourceProvider::SetPromotionHint(ResourceId resource, bool promote) which
internally can do the GL call (which should be straightforward after a few
DCHECKs, don't necessarily need the whole ScopedReadLockGL)
- pass the ResourceProvider to the
OverlayCandidateValidator::CheckOverlaySupport and have it issue the hints on
the resources you want to promote

[liberato (no reviews please), 2016/12/01 20:59:11]

i'll try to do that.

the trick is that OverlayCandidateValidator::CheckOverlaySupport doesn't know
what the correct hint is for the resource by the time it returns.  It has to
wait until all resources are processed to see if any are promoted, since we'll
promote at most one.  promotable resources become unpromotable if some other
resource is actually promoted.

i really don't like having CheckOverlaySupport have this stateful set of
resources that i added.  i'll try to get rid of that too, since it really goes
with the candidate list.

+  LOG(ERROR) << "AVDA: " << __FUNCTION__ << ": promotable: " << is_promotable;
+
   ToGLMatrix(&gl_matrix[0], quad->matrix);
 
   ResourceProvider::ScopedReadLockGL lock(resource_provider_,
                                           quad->resource_id());
 
   DCHECK_EQ(GL_TEXTURE0, GetActiveTextureUnit(gl_));
   gl_->BindTexture(GL_TEXTURE_EXTERNAL_OES, lock.texture_id());
 
   gl_->UniformMatrix4fvStreamTextureMatrixCHROMIUM(
       program->vertex_shader().tex_matrix_location(), false, gl_matrix);
@@ skipping 1560 matching lines @@
   // The alpha has already been applied when copying the RPDQ to an IOSurface.
   GLfloat alpha = 1;
   gl_->ScheduleCALayerSharedStateCHROMIUM(alpha, is_clipped, clip_rect,
                                           sorting_context_id, gl_transform);
   gl_->ScheduleCALayerCHROMIUM(
       texture_id, contents_rect, ca_layer_overlay->background_color,
       ca_layer_overlay->edge_aa_mask, bounds_rect, filter);
 }
 
 }  // namespace cc