Web Animations CSS: Split AnimatableNumber into AnimatableDouble and AnimatableLength

Source/core/animation/AnimatableDouble.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 10 matching lines @@
  * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef AnimatableTransform_h
-#define AnimatableTransform_h
+#ifndef AnimatableDouble_h
+#define AnimatableDouble_h
 
 #include "core/animation/AnimatableValue.h"
-#include "core/platform/graphics/transforms/TransformOperations.h"
+#include "core/css/CSSValue.h"
+#include "wtf/MathExtras.h"

[Timothy Loh, 2013/09/30 23:27:59]

Is this used here?

[alancutter (OOO until 2018), 2013/10/01 09:32:24]

Removed.

 
 namespace WebCore {
 
-class AnimatableTransform : public AnimatableValue {
+class AnimatableDouble : public AnimatableValue {
 public:
-    virtual ~AnimatableTransform() { }
-    static PassRefPtr<AnimatableTransform> create(const TransformOperations&);
-    const TransformOperations& transformOperations() const
+    virtual ~AnimatableDouble() { }
+
+    static PassRefPtr<AnimatableDouble> create(double number)
     {
-        return m_transform;
+        return adoptRef(new AnimatableDouble(number));
     }
 
+    PassRefPtr<CSSValue> toCSSValue() const;
+    double toDouble() const { return m_number; }
+
 protected:
     virtual PassRefPtr<AnimatableValue> interpolateTo(const AnimatableValue*, double fraction) const OVERRIDE;
     virtual PassRefPtr<AnimatableValue> addWith(const AnimatableValue*) const OVERRIDE;
 
 private:
-    explicit AnimatableTransform(const TransformOperations& transform)
-        : m_transform(transform)
+    AnimatableDouble(double number)
+        : m_number(number)
     {
     }
-    virtual AnimatableType type() const OVERRIDE { return TypeTransform; }
-    const TransformOperations m_transform;
+    virtual AnimatableType type() const OVERRIDE { return TypeDouble; }
+
+    double m_number;
 };
 
-inline const AnimatableTransform* toAnimatableTransform(const AnimatableValue* value)
+inline const AnimatableDouble* toAnimatableDouble(const AnimatableValue* value)
 {
-    ASSERT_WITH_SECURITY_IMPLICATION(value && value->isTransform());
-    return static_cast<const AnimatableTransform*>(value);
+    ASSERT_WITH_SECURITY_IMPLICATION(value && value->isDouble());
+    return static_cast<const AnimatableDouble*>(value);
 }
 
 } // namespace WebCore
 
-#endif // AnimatableTransform_h
-
+#endif // AnimatableDouble_h