Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2508183002:
Fix vertical spacing of extended reporting checkbox. (Closed)
|
Created:
4 years, 1 month ago by lpz Modified:
4 years, 1 month ago Reviewers:
Dan Beam CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix vertical spacing of extended reporting checkbox.
This was broken by my recent change to change this checkbox from a settings-checkbox to a paper-checkbox (but forgot to include the style config).
BUG=666176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/1f3740f5dc6c9f858523f8a2fdb92a0b8d980ee8
Cr-Commit-Position: refs/heads/master@{#433007}
Patch Set 1 #
Total comments: 2
Patch Set 2 : share paper-checkbox settings #
Total comments: 2
Patch Set 3 : remove extra whitespace #Messages
Total messages: 24 (15 generated)
Description was changed from ========== Fix vertical spacing of extended reporting checkbox. BUG=666176 ========== to ========== Fix vertical spacing of extended reporting checkbox. BUG=666176 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by lpz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix vertical spacing of extended reporting checkbox. BUG=666176 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Fix vertical spacing of extended reporting checkbox. This was broken by my recent change to change this checkbox from a settings-checkbox to a paper-checkbox (but forgot to include the style config). BUG=666176 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
lpz@chromium.org changed reviewers: + dbeam@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
The CQ bit was checked by lpz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2508183002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/privacy_page/privacy_page.html (right): https://codereview.chromium.org/2508183002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/privacy_page/privacy_page.html:42: #metricsReporting { #metricsReporting, #safeBrowsingExtendedReporting { ... same rules ... } or make a class
thanks for noticing btw, I was just about to fix this.
The CQ bit was checked by lpz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2508183002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/privacy_page/privacy_page.html (right): https://codereview.chromium.org/2508183002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/privacy_page/privacy_page.html:42: #metricsReporting { On 2016/11/17 19:11:28, Dan Beam wrote: > #metricsReporting, > #safeBrowsingExtendedReporting { > ... same rules ... > } > > or make a class Done.
lgtm https://codereview.chromium.org/2508183002/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/privacy_page/privacy_page.html (right): https://codereview.chromium.org/2508183002/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/privacy_page/privacy_page.html:66: nit: remove
The CQ bit was checked by lpz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org Link to the patchset: https://codereview.chromium.org/2508183002/#ps40001 (title: "remove extra whitespace")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2508183002/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/privacy_page/privacy_page.html (right): https://codereview.chromium.org/2508183002/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/privacy_page/privacy_page.html:66: On 2016/11/17 19:24:02, Dan Beam wrote: > nit: remove Done.
Message was sent while issue was closed.
Description was changed from ========== Fix vertical spacing of extended reporting checkbox. This was broken by my recent change to change this checkbox from a settings-checkbox to a paper-checkbox (but forgot to include the style config). BUG=666176 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Fix vertical spacing of extended reporting checkbox. This was broken by my recent change to change this checkbox from a settings-checkbox to a paper-checkbox (but forgot to include the style config). BUG=666176 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Fix vertical spacing of extended reporting checkbox. This was broken by my recent change to change this checkbox from a settings-checkbox to a paper-checkbox (but forgot to include the style config). BUG=666176 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Fix vertical spacing of extended reporting checkbox. This was broken by my recent change to change this checkbox from a settings-checkbox to a paper-checkbox (but forgot to include the style config). BUG=666176 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/1f3740f5dc6c9f858523f8a2fdb92a0b8d980ee8 Cr-Commit-Position: refs/heads/master@{#433007} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/1f3740f5dc6c9f858523f8a2fdb92a0b8d980ee8 Cr-Commit-Position: refs/heads/master@{#433007} |
