Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 2508173002: Force first backup (Closed)

Created:
4 years, 1 month ago by aberent
Modified:
4 years, 1 month ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Force first backup If, at startup, Chrome has never been backed (on Android backup) force an immediate backup BUG=666334 Committed: https://crrev.com/05d89a7436af1e995d74a7ef8fa5a97ed4d8873f Cr-Commit-Position: refs/heads/master@{#432905}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupWatcher.java View 2 chunks +7 lines, -0 lines 2 comments Download

Messages

Total messages: 9 (3 generated)
aberent
4 years, 1 month ago (2016-11-17 16:01:58 UTC) #2
Bernhard Bauer
lgtm https://codereview.chromium.org/2508173002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupWatcher.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupWatcher.java (right): https://codereview.chromium.org/2508173002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupWatcher.java#newcode43 chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupWatcher.java:43: sharedPrefs.edit().putBoolean(FIRST_BACKUP_DONE, true).apply(); Actually, would it make sense to ...
4 years, 1 month ago (2016-11-17 16:08:32 UTC) #3
aberent
https://codereview.chromium.org/2508173002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupWatcher.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupWatcher.java (right): https://codereview.chromium.org/2508173002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupWatcher.java#newcode43 chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupWatcher.java:43: sharedPrefs.edit().putBoolean(FIRST_BACKUP_DONE, true).apply(); On 2016/11/17 16:08:32, Bernhard Bauer wrote: > ...
4 years, 1 month ago (2016-11-17 16:58:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508173002/1
4 years, 1 month ago (2016-11-17 16:59:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 17:48:38 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 18:08:56 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05d89a7436af1e995d74a7ef8fa5a97ed4d8873f
Cr-Commit-Position: refs/heads/master@{#432905}

Powered by Google App Engine
This is Rietveld 408576698