Force first backup

Force first backup

If, at startup, Chrome has never been backed (on Android backup) force
an immediate backup

BUG=666334
Committed: https://crrev.com/05d89a7436af1e995d74a7ef8fa5a97ed4d8873f
Cr-Commit-Position: refs/heads/master@{#432905}

[aberent, 2016-11-17 16:01:58]

aberent@chromium.org changed reviewers:
+ bauerb@chromium.org

[Bernhard Bauer, 2016-11-17 16:08:32]

lgtm

https://codereview.chromium.org/2508173002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupWatcher.java
(right):

https://codereview.chromium.org/2508173002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupWatcher.java:43:
sharedPrefs.edit().putBoolean(FIRST_BACKUP_DONE, true).apply();
Actually, would it make sense to set this flag as well when restoring a backup?

[aberent, 2016-11-17 16:58:54]

https://codereview.chromium.org/2508173002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupWatcher.java
(right):

https://codereview.chromium.org/2508173002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupWatcher.java:43:
sharedPrefs.edit().putBoolean(FIRST_BACKUP_DONE, true).apply();
On 2016/11/17 16:08:32, Bernhard Bauer wrote:
> Actually, would it make sense to set this flag as well when restoring a
backup?

First run on a new device will always change some of the things we watch so will
always request a backup anyway. I found it much easier to do a silent first run
to set up the user rather than trying to restore everything that user signin
changes, and this silent first run changes some of the preferences we watch (in
particular, to force this, we restore the original SIGNED_IN_ACCOUNT_KEY to the
FIRST_RUN_FLOW_SIGNIN_ACCOUNT_NAME, the silent first run will then restore the
SIGNED_IN_ACCOUNT_KEY). Avoiding this would have been complex, and the cost of
the current behaviour is small (and it only happens once per device).

[aberent, 2016-11-17 16:59:00]

The CQ bit was checked by aberent@chromium.org

[commit-bot: I haz the power, 2016-11-17 16:59:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 17:48:38]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-17 18:08:55]

Description was changed from

==========
Force first backup

If, at startup, Chrome has never been backed (on Android backup) force
an immediate backup

BUG=666334
==========

to

==========
Force first backup

If, at startup, Chrome has never been backed (on Android backup) force
an immediate backup

BUG=666334

Committed: https://crrev.com/05d89a7436af1e995d74a7ef8fa5a97ed4d8873f
Cr-Commit-Position: refs/heads/master@{#432905}
==========

[commit-bot: I haz the power, 2016-11-17 18:08:56]

Patchset 1 (id:??) landed as
https://crrev.com/05d89a7436af1e995d74a7ef8fa5a97ed4d8873f
Cr-Commit-Position: refs/heads/master@{#432905}