Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2508153002: [chrome.displaySource] Switch mojom targets to use STL types. (Closed)

Created:
4 years, 1 month ago by e_hakkinen
Modified:
4 years, 1 month ago
CC:
chromium-reviews, extensions-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, chromium-apps-reviews_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chrome.displaySource] Switch mojom targets to use STL types. BUG=242107, 624136 Committed: https://crrev.com/80ff2be8079778b471c4afdf0a3061f5f088376f Cr-Commit-Position: refs/heads/master@{#433495}

Patch Set 1 #

Patch Set 2 : OWNERS #

Messages

Total messages: 19 (8 generated)
e_hakkinen
PTAL.
4 years, 1 month ago (2016-11-17 15:39:57 UTC) #2
Mikhail
lgtm
4 years, 1 month ago (2016-11-17 16:45:14 UTC) #3
asargent_no_longer_on_chrome
lgtm
4 years, 1 month ago (2016-11-17 20:34:13 UTC) #4
shalamov
lgtm
4 years, 1 month ago (2016-11-18 07:22:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508153002/1
4 years, 1 month ago (2016-11-18 10:47:23 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/308095)
4 years, 1 month ago (2016-11-18 10:54:30 UTC) #9
e_hakkinen
+@dcheng: extensions/common/mojo/wifi_display_session_service.mojom
4 years, 1 month ago (2016-11-18 11:14:28 UTC) #11
dcheng
this CL LGTM, but it appears that these interfaces never went through ipc security review. ...
4 years, 1 month ago (2016-11-18 18:32:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508153002/20001
4 years, 1 month ago (2016-11-21 08:36:18 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-21 08:48:36 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 08:50:52 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/80ff2be8079778b471c4afdf0a3061f5f088376f
Cr-Commit-Position: refs/heads/master@{#433495}

Powered by Google App Engine
This is Rietveld 408576698