Prerender: add true simultaneous nostate prefetch test.

Prerender: add true simultaneous nostate prefetch test.

BUG=666306
Committed: https://crrev.com/50bf87a5fa8874cd37a334e402c6931f55641335
Cr-Commit-Position: refs/heads/master@{#433158}

[mattcary, 2016-11-17 14:53:46]

mattcary@chromium.org changed reviewers:
+ droger@chromium.org, pasko@chromium.org

[droger, 2016-11-17 17:08:40]

lgtm

[pasko, 2016-11-17 17:14:18]

it would have been helpful to say in the issue description that
HangingURLRequestJob and HangingFirstRequestInterceptor were moved from
prerender_browsertest.cc to prerender_test_utils.*.
</grumpy>

looking further

[pasko, 2016-11-17 17:19:28]

lgtm with a naming nit, neat!

https://codereview.chromium.org/2508143002/diff/1/chrome/browser/prerender/pr...
File chrome/browser/prerender/prerender_test_utils.cc (right):

https://codereview.chromium.org/2508143002/diff/1/chrome/browser/prerender/pr...
chrome/browser/prerender/prerender_test_utils.cc:711:
std::unique_ptr<net::URLRequestInterceptor> never_respond_handler(
nit: 'never' sounds confusing since it will respond eventually, perhaps just
'interceptor'?

[mattcary, 2016-11-18 08:22:55]

https://codereview.chromium.org/2508143002/diff/1/chrome/browser/prerender/pr...
File chrome/browser/prerender/prerender_test_utils.cc (right):

https://codereview.chromium.org/2508143002/diff/1/chrome/browser/prerender/pr...
chrome/browser/prerender/prerender_test_utils.cc:711:
std::unique_ptr<net::URLRequestInterceptor> never_respond_handler(
On 2016/11/17 17:19:28, pasko wrote:
> nit: 'never' sounds confusing since it will respond eventually, perhaps just
> 'interceptor'?

Done.

This was old code that was moved, but since I didn't warn you about it, I
suppose it's fair game ;)

[mattcary, 2016-11-18 08:26:14]

The CQ bit was checked by mattcary@chromium.org

[mattcary, 2016-11-18 08:26:14]

The patchset sent to the CQ was uploaded after l-g-t-m from pasko@chromium.org,
droger@chromium.org
Link to the patchset: https://codereview.chromium.org/2508143002/#ps20001
(title: "comments")

[commit-bot: I haz the power, 2016-11-18 08:26:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 09:12:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-18 09:13:21]

Description was changed from

==========
Prerender: add true simultaneous nostate prefetch test.

BUG=666306
==========

to

==========
Prerender: add true simultaneous nostate prefetch test.

BUG=666306

Committed: https://crrev.com/50bf87a5fa8874cd37a334e402c6931f55641335
Cr-Commit-Position: refs/heads/master@{#433158}
==========

[commit-bot: I haz the power, 2016-11-18 09:13:23]

Patchset 2 (id:??) landed as
https://crrev.com/50bf87a5fa8874cd37a334e402c6931f55641335
Cr-Commit-Position: refs/heads/master@{#433158}