Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 2508143002: Prerender: add true simultaneous nostate prefetch test. (Closed)

Created:
4 years, 1 month ago by mattcary
Modified:
4 years, 1 month ago
Reviewers:
pasko, droger
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prerender: add true simultaneous nostate prefetch test. BUG=666306 Committed: https://crrev.com/50bf87a5fa8874cd37a334e402c6931f55641335 Cr-Commit-Position: refs/heads/master@{#433158}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -68 lines) Patch
M chrome/browser/prerender/prerender_browsertest.cc View 2 chunks +1 line, -61 lines 0 comments Download
M chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc View 3 chunks +33 lines, -7 lines 0 comments Download
M chrome/browser/prerender/prerender_test_utils.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/prerender/prerender_test_utils.cc View 1 2 chunks +58 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
mattcary
4 years, 1 month ago (2016-11-17 14:53:47 UTC) #2
droger
lgtm
4 years, 1 month ago (2016-11-17 17:08:40 UTC) #3
pasko
it would have been helpful to say in the issue description that HangingURLRequestJob and HangingFirstRequestInterceptor ...
4 years, 1 month ago (2016-11-17 17:14:18 UTC) #4
pasko
lgtm with a naming nit, neat! https://codereview.chromium.org/2508143002/diff/1/chrome/browser/prerender/prerender_test_utils.cc File chrome/browser/prerender/prerender_test_utils.cc (right): https://codereview.chromium.org/2508143002/diff/1/chrome/browser/prerender/prerender_test_utils.cc#newcode711 chrome/browser/prerender/prerender_test_utils.cc:711: std::unique_ptr<net::URLRequestInterceptor> never_respond_handler( nit: ...
4 years, 1 month ago (2016-11-17 17:19:28 UTC) #5
mattcary
https://codereview.chromium.org/2508143002/diff/1/chrome/browser/prerender/prerender_test_utils.cc File chrome/browser/prerender/prerender_test_utils.cc (right): https://codereview.chromium.org/2508143002/diff/1/chrome/browser/prerender/prerender_test_utils.cc#newcode711 chrome/browser/prerender/prerender_test_utils.cc:711: std::unique_ptr<net::URLRequestInterceptor> never_respond_handler( On 2016/11/17 17:19:28, pasko wrote: > nit: ...
4 years, 1 month ago (2016-11-18 08:22:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508143002/20001
4 years, 1 month ago (2016-11-18 08:26:38 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-18 09:12:02 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 09:13:23 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/50bf87a5fa8874cd37a334e402c6931f55641335
Cr-Commit-Position: refs/heads/master@{#433158}

Powered by Google App Engine
This is Rietveld 408576698