Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2508133004: [NTP] Refresh download list when NTP is open. (Closed)

Created:
4 years, 1 month ago by vitaliii
Modified:
4 years, 1 month ago
CC:
agrieve+watch_chromium.org, chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP] Refresh download list when NTP is open. So that we do not show on new NTPs items which were removed bypassing Chrome. BUG=666262 Committed: https://crrev.com/a17ba56880d3431adc2626ee006f7f65e703c84d Cr-Commit-Position: refs/heads/master@{#433174}

Patch Set 1 #

Total comments: 2

Patch Set 2 : inlined context. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
markusheintz_
https://codereview.chromium.org/2508133004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java (right): https://codereview.chromium.org/2508133004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java#newcode750 chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java:750: Context context = mNewTabPageView.getContext(); Drive by : I guess ...
4 years, 1 month ago (2016-11-17 18:28:11 UTC) #4
vitaliii
Addressed Markus' comments. https://codereview.chromium.org/2508133004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java (right): https://codereview.chromium.org/2508133004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java#newcode750 chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java:750: Context context = mNewTabPageView.getContext(); On 2016/11/17 ...
4 years, 1 month ago (2016-11-17 18:46:51 UTC) #5
vitaliii
Hi Bernhard, please have a look or redirect if appropriate.
4 years, 1 month ago (2016-11-18 06:24:02 UTC) #11
vitaliii
Hi Bernhard, please have a look or redirect if appropriate.
4 years, 1 month ago (2016-11-18 06:25:34 UTC) #13
Bernhard Bauer
lgtm
4 years, 1 month ago (2016-11-18 10:52:39 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508133004/20001
4 years, 1 month ago (2016-11-18 10:53:56 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-18 11:00:36 UTC) #18
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a17ba56880d3431adc2626ee006f7f65e703c84d Cr-Commit-Position: refs/heads/master@{#433174}
4 years, 1 month ago (2016-11-18 11:03:19 UTC) #20
Benoit L
4 years, 1 month ago (2016-11-18 14:49:20 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2511973005/ by lizeb@chromium.org.

The reason for reverting is: Broke tests.
See crbug.com/666744.

Powered by Google App Engine
This is Rietveld 408576698