|
|
Chromium Code Reviews
Description[NTP] Refresh download list when NTP is open.
So that we do not show on new NTPs items which were removed bypassing Chrome.
BUG=666262
Committed: https://crrev.com/a17ba56880d3431adc2626ee006f7f65e703c84d
Cr-Commit-Position: refs/heads/master@{#433174}
Patch Set 1 #
Total comments: 2
Patch Set 2 : inlined context. #Messages
Total messages: 21 (12 generated)
The CQ bit was checked by vitaliii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
markusheintz@chromium.org changed reviewers: + markusheintz@chromium.org
https://codereview.chromium.org/2508133004/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java (right): https://codereview.chromium.org/2508133004/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java:750: Context context = mNewTabPageView.getContext(); Drive by : I guess you can inline getting the context.
Addressed Markus' comments. https://codereview.chromium.org/2508133004/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java (right): https://codereview.chromium.org/2508133004/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java:750: Context context = mNewTabPageView.getContext(); On 2016/11/17 18:28:11, markusheintz_ wrote: > Drive by : I guess you can inline getting the context. Done.
The CQ bit was checked by vitaliii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
vitaliii@chromium.org changed reviewers: + bernrb@chromium.org
Hi Bernhard, please have a look or redirect if appropriate.
vitaliii@chromium.org changed reviewers: + bauerb@chromium.org - bernrb@chromium.org
Hi Bernhard, please have a look or redirect if appropriate.
Description was changed from ========== [NTP] Refresh download list when NTP is open. So that we do not show items which were removed out of Chrome on new NTPs. BUG=666262 ========== to ========== [NTP] Refresh download list when NTP is open. So that we do not show on new NTPs items which were removed bypassing Chrome. BUG=666262 ==========
lgtm
The CQ bit was checked by vitaliii@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [NTP] Refresh download list when NTP is open. So that we do not show on new NTPs items which were removed bypassing Chrome. BUG=666262 ========== to ========== [NTP] Refresh download list when NTP is open. So that we do not show on new NTPs items which were removed bypassing Chrome. BUG=666262 Committed: https://crrev.com/a17ba56880d3431adc2626ee006f7f65e703c84d Cr-Commit-Position: refs/heads/master@{#433174} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/a17ba56880d3431adc2626ee006f7f65e703c84d Cr-Commit-Position: refs/heads/master@{#433174}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2511973005/ by lizeb@chromium.org. The reason for reverting is: Broke tests. See crbug.com/666744. |
