Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 250813002: Telemetry: Add a reduced compositor cases page set. (Closed)

Created:
6 years, 8 months ago by epenner
Modified:
6 years, 7 months ago
Reviewers:
nduca, dtu, vmiura, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Telemetry: Add a reduced compositor cases page set. These are setup to have almost no cpu-time noise. There is always only one frame source, and we either scroll 4 times or wait for 10 seconds worth of frames. Since these are jsbin pages, I've added a '?' label to give the URL more meaning. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269674

Patch Set 1 : #

Patch Set 2 : Rebase. #

Patch Set 3 : Use new page-set #

Patch Set 4 : Add recordings. #

Patch Set 5 : Record pageset. #

Total comments: 3

Patch Set 6 : Use Page #

Patch Set 7 : Whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -5 lines) Patch
M tools/perf/benchmarks/thread_times.py View 1 2 3 4 5 6 2 chunks +8 lines, -5 lines 0 comments Download
A tools/perf/page_sets/data/tough_compositor_cases.json View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/tough_compositor_cases_000.wpr.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/tough_compositor_cases.py View 1 2 3 4 5 1 chunk +79 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
epenner
Ptal.
6 years, 8 months ago (2014-04-26 03:46:40 UTC) #1
epenner
On 2014/04/26 03:46:40, epenner wrote: > Ptal. Polite ping. I'm going to be off for ...
6 years, 7 months ago (2014-04-28 22:01:26 UTC) #2
vmiura
On 2014/04/28 22:01:26, epenner wrote: > On 2014/04/26 03:46:40, epenner wrote: > > Ptal. > ...
6 years, 7 months ago (2014-04-29 01:42:01 UTC) #3
epennerAtGoogle
On 2014/04/29 01:42:01, vmiura wrote: > On 2014/04/28 22:01:26, epenner wrote: > > On 2014/04/26 ...
6 years, 7 months ago (2014-04-29 02:11:40 UTC) #4
epenner
Rebased. Ptal.
6 years, 7 months ago (2014-05-01 18:22:18 UTC) #5
epenner
On 2014/05/01 18:22:18, epenner wrote: > Rebased. Ptal. Oops, I didn't upload the rebase. Not ...
6 years, 7 months ago (2014-05-01 18:38:43 UTC) #6
tonyg
I thought that key_mobile_sites was supposed to represent important (or key) mobile sites that we ...
6 years, 7 months ago (2014-05-02 04:01:04 UTC) #7
epennerAtGoogle
On 2014/05/02 04:01:04, tonyg wrote: > I thought that key_mobile_sites was supposed to represent important ...
6 years, 7 months ago (2014-05-02 18:44:53 UTC) #8
epenner
Ptal. I've added a new page set. I'll add the recordings before landing, and I'll ...
6 years, 7 months ago (2014-05-02 20:49:12 UTC) #9
epenner
Added the recordings etc.
6 years, 7 months ago (2014-05-02 21:56:33 UTC) #10
epenner
On 2014/05/02 21:56:33, epenner wrote: > Added the recordings etc. Ptal (pretty please with sugar ...
6 years, 7 months ago (2014-05-08 22:19:13 UTC) #11
vmiura
https://codereview.chromium.org/250813002/diff/220001/tools/perf/page_sets/tough_compositor_cases.py File tools/perf/page_sets/tough_compositor_cases.py (right): https://codereview.chromium.org/250813002/diff/220001/tools/perf/page_sets/tough_compositor_cases.py#newcode10 tools/perf/page_sets/tough_compositor_cases.py:10: class ToughCompositorPage(page_module.PageWithDefaultRunNavigate): PageWithDefaultRunNavigate seems to have gone away. Use ...
6 years, 7 months ago (2014-05-08 23:19:24 UTC) #12
dtu
lgtm with nit https://codereview.chromium.org/250813002/diff/220001/tools/perf/benchmarks/thread_times.py File tools/perf/benchmarks/thread_times.py (right): https://codereview.chromium.org/250813002/diff/220001/tools/perf/benchmarks/thread_times.py#newcode43 tools/perf/benchmarks/thread_times.py:43: class ThreadTimesCompositorCases(test.Test): nit: two blank lines ...
6 years, 7 months ago (2014-05-09 00:05:39 UTC) #13
epenner
Thanks! > ThreadTimesCompositorCases(test.Test): > nit: two blank lines between top-level blocks > Done. > > ...
6 years, 7 months ago (2014-05-10 06:38:27 UTC) #14
epenner
The CQ bit was checked by epenner@chromium.org
6 years, 7 months ago (2014-05-10 06:38:33 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/250813002/260001
6 years, 7 months ago (2014-05-10 06:43:23 UTC) #16
commit-bot: I haz the power
6 years, 7 months ago (2014-05-11 01:18:34 UTC) #17
Message was sent while issue was closed.
Change committed as 269674

Powered by Google App Engine
This is Rietveld 408576698