Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2508103002:
Free the native delegate when the user accepts a modal permission dialog. (Closed)
DescriptionFree the native delegate when the user accepts a modal permission dialog.
This corrects an oversight where PermissionDialogDelegate#destroy was
not called when allowing a modal permission prompt, leaking to a memory
leak.
BUG=658125
Committed: https://crrev.com/97672a1b334602c3634b635625d8896da3a58ba2
Cr-Commit-Position: refs/heads/master@{#433035}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Address comments #
Depends on Patchset: Messages
Total messages: 25 (14 generated)
The CQ bit was checked by dominickn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
dominickn@chromium.org changed reviewers: + dfalcantara@chromium.org
PTAL, thanks. "Oops".
lgtm % cleanup https://codereview.chromium.org/2508103002/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/permissions/PermissionDialogController.java (right): https://codereview.chromium.org/2508103002/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/permissions/PermissionDialogController.java:105: mDialogDelegate.destroy(); Pull these three lines out; you've repeated them a few times now.
Thanks! https://codereview.chromium.org/2508103002/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/permissions/PermissionDialogController.java (right): https://codereview.chromium.org/2508103002/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/permissions/PermissionDialogController.java:105: mDialogDelegate.destroy(); On 2016/11/17 20:17:29, dfalcantara (check my queue) wrote: > Pull these three lines out; you've repeated them a few times now. Done, though I just pulled the destroy and nulling lines out to use this in one more spot.
The CQ bit was checked by dominickn@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dfalcantara@chromium.org Link to the patchset: https://codereview.chromium.org/2508103002/#ps20001 (title: "Address comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply the patch.
The CQ bit was checked by dominickn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply the patch.
The CQ bit was checked by dominickn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by dominickn@chromium.org
The CQ bit was checked by dominickn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Free the native delegate when the user accepts a modal permission dialog. This corrects an oversight where PermissionDialogDelegate#destroy was not called when allowing a modal permission prompt, leaking to a memory leak. BUG=658125 ========== to ========== Free the native delegate when the user accepts a modal permission dialog. This corrects an oversight where PermissionDialogDelegate#destroy was not called when allowing a modal permission prompt, leaking to a memory leak. BUG=658125 Committed: https://crrev.com/97672a1b334602c3634b635625d8896da3a58ba2 Cr-Commit-Position: refs/heads/master@{#433035} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/97672a1b334602c3634b635625d8896da3a58ba2 Cr-Commit-Position: refs/heads/master@{#433035} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
