Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2508093002:
Add export annotation to fix component build (Closed)
|
Created:
4 years, 1 month ago by Michael Achenbach Modified:
4 years, 1 month ago CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionAdd export annotation to fix component build
BUG=v8:5628
NOTRY=true
Committed: https://crrev.com/28777644713b3508d6e320e180ca8542c78c0203
Cr-Commit-Position: refs/heads/master@{#41063}
Patch Set 1 #
Messages
Total messages: 17 (10 generated)
Description was changed from ========== Add export annotation to fix component build BUG= ========== to ========== Add export annotation to fix component build BUG=v8:5628 ==========
machenbach@chromium.org changed reviewers: + ishell@chromium.org, jgruber@chromium.org, jkummerow@chromium.org
PTAL. Fixes the problem in https://codereview.chromium.org/2502293002/ rather than revert. Need to backmerge this to unblock roll: https://codereview.chromium.org/2502363002/
Description was changed from ========== Add export annotation to fix component build BUG=v8:5628 ========== to ========== Add export annotation to fix component build BUG=v8:5628 NOTRY=true ==========
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
lgtm
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add export annotation to fix component build BUG=v8:5628 NOTRY=true ========== to ========== Add export annotation to fix component build BUG=v8:5628 NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Thanks!
Message was sent while issue was closed.
Description was changed from ========== Add export annotation to fix component build BUG=v8:5628 NOTRY=true ========== to ========== Add export annotation to fix component build BUG=v8:5628 NOTRY=true Committed: https://crrev.com/28777644713b3508d6e320e180ca8542c78c0203 Cr-Commit-Position: refs/heads/master@{#41063} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/28777644713b3508d6e320e180ca8542c78c0203 Cr-Commit-Position: refs/heads/master@{#41063} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
