arc: enable use_new_wrapper_types for bitmap.mojom

arc: enable use_new_wrapper_types for bitmap.mojom

BUG=665964
Committed: https://crrev.com/3b646e620b370524fe003a449454c7d1f702aa9a
Cr-Commit-Position: refs/heads/master@{#433110}

[yoshiki, 2016-11-17 04:32:19]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 04:33:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoshiki, 2016-11-17 05:49:21]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[yoshiki, 2016-11-17 05:49:41]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-11-17 05:49:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoshiki, 2016-11-17 06:01:14]

Description was changed from

==========
.

BUG=
==========

to

==========
arc: enable use_new_wrapper_types for bitmap.mojom

BUG=665964
==========

[yoshiki, 2016-11-17 06:01:14]

yoshiki@chromium.org changed reviewers:
+ yusukes@chromium.org, yzshen@chromium.org

[commit-bot: I haz the power, 2016-11-17 08:30:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 08:30:13]

Dry run: This issue passed the CQ dry run.

[Yusuke Sato, 2016-11-17 17:41:28]

Interesting. When I tried this locally on my workstation, Chromium build failed
with lots of skia (#include "SkXXX.h") errors, and I assumed that some sort of
migration work was needed... Looks like my Chromium checkout was just broken at
that time.

Either way, LGTM. Thanks!

[Yusuke Sato, 2016-11-17 22:12:12]

The CQ bit was checked by yusukes@chromium.org

[commit-bot: I haz the power, 2016-11-17 22:13:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 23:13:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 23:13:33]

Failed to apply patch for components/arc/BUILD.gn:
While running git apply --index -p1;
  error: patch failed: components/arc/BUILD.gn:127
  error: components/arc/BUILD.gn: patch does not apply

Patch:       components/arc/BUILD.gn
Index: components/arc/BUILD.gn
diff --git a/components/arc/BUILD.gn b/components/arc/BUILD.gn
index
2a28210490d2a3beb170ab079bc36b10bbbdfa4b..77657eb86c97499838283aa80549677ccc794ba6
100644
--- a/components/arc/BUILD.gn
+++ b/components/arc/BUILD.gn
@@ -127,7 +127,6 @@ static_library("arc_base") {
 # TODO(crbug.com/662510): Remove this altogether.
 mojom("arc_bindings_old_types") {
   sources = [
-    "common/bitmap.mojom",
     "common/bluetooth.mojom",
     "common/enterprise_reporting.mojom",
     "common/net.mojom",
@@ -148,6 +147,7 @@ mojom("arc_bindings") {
     "common/arc_bridge.mojom",
     "common/audio.mojom",
     "common/auth.mojom",
+    "common/bitmap.mojom",
     "common/boot_phase_monitor.mojom",
     "common/clipboard.mojom",
     "common/crash_collector.mojom",

[yoshiki, 2016-11-17 23:32:12]

Yusuke, Yuzhu, I don't think we need to modify bitmap_struct_traits.cc, but I
have no confidence. Could you double check?

bitmap_struct_traits.cc:
https://cs.chromium.org/chromium/src/components/arc/bitmap/bitmap_struct_trai...

[yoshiki, 2016-11-18 02:14:23]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 02:16:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoshiki, 2016-11-18 02:17:04]

I chatted with Yusuke-san. The patch looks working so let me submit.

Yuzhu, if we need to modify the code further, please let me know. I'll create a
separated CL.

[yzshen1, 2016-11-18 02:23:12]

On 2016/11/18 02:17:04, yoshiki wrote:
> I chatted with Yusuke-san. The patch looks working so let me submit.
> 
> Yuzhu, if we need to modify the code further, please let me know. I'll create
a
> separated CL.

Yeah, I don't think you need to modify bitmap_struct_traits.cc

LGTM

[yoshiki, 2016-11-18 02:26:59]

On 2016/11/18 02:23:12, yzshen1 wrote:
> On 2016/11/18 02:17:04, yoshiki wrote:
> > I chatted with Yusuke-san. The patch looks working so let me submit.
> > 
> > Yuzhu, if we need to modify the code further, please let me know. I'll
create
> a
> > separated CL.
> 
> Yeah, I don't think you need to modify bitmap_struct_traits.cc
> 
> LGTM

Thanks! I'm relieved.

[commit-bot: I haz the power, 2016-11-18 02:29:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 02:29:09]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[yoshiki, 2016-11-18 04:20:28]

The CQ bit was checked by yoshiki@chromium.org

[yoshiki, 2016-11-18 04:20:28]

The patchset sent to the CQ was uploaded after l-g-t-m from yusukes@chromium.org
Link to the patchset: https://codereview.chromium.org/2508073002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-18 04:21:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 04:41:24]

Description was changed from

==========
arc: enable use_new_wrapper_types for bitmap.mojom

BUG=665964
==========

to

==========
arc: enable use_new_wrapper_types for bitmap.mojom

BUG=665964
==========

[commit-bot: I haz the power, 2016-11-18 04:41:26]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-11-18 04:48:19]

Description was changed from

==========
arc: enable use_new_wrapper_types for bitmap.mojom

BUG=665964
==========

to

==========
arc: enable use_new_wrapper_types for bitmap.mojom

BUG=665964

Committed: https://crrev.com/3b646e620b370524fe003a449454c7d1f702aa9a
Cr-Commit-Position: refs/heads/master@{#433110}
==========

[commit-bot: I haz the power, 2016-11-18 04:48:21]

Patchset 2 (id:??) landed as
https://crrev.com/3b646e620b370524fe003a449454c7d1f702aa9a
Cr-Commit-Position: refs/heads/master@{#433110}