Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Issue 2508063004: Take size in ink drop masks instead of bounds (Closed)

Created:
4 years, 1 month ago by mohsen
Modified:
4 years, 1 month ago
Reviewers:
James Cook, bruthig
CC:
bruthig+ink_drop_chromium.org, chromium-reviews, dcheng, kalyank, sadrul, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Take size in ink drop masks instead of bounds Currently, constructors for ink drop masks, take layer bounds which is expected to have (0, 0) as their origin. It's better for them to take size instead. BUG=612573 TEST=none Committed: https://crrev.com/431883e99a2fcdc5e6e54868ac98d3474aaaf198 Committed: https://crrev.com/7c8b9453199a880668feab3a3f1bf39ca603a447 Cr-Original-Commit-Position: refs/heads/master@{#432898} Cr-Commit-Position: refs/heads/master@{#432971}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -16 lines) Patch
M ash/common/shelf/app_list_button.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/common/system/tray/tray_background_view.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M ash/common/system/tray/tray_popup_utils.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/animation/ink_drop_mask.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/views/animation/ink_drop_mask.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 26 (16 generated)
mohsen
+bruthig@ for changes in /ui/views/animation/. +jamescook@ for changes in /ash/.
4 years, 1 month ago (2016-11-17 05:08:32 UTC) #4
bruthig
lgtm
4 years, 1 month ago (2016-11-17 05:56:18 UTC) #6
James Cook
LGTM. Nice simplification.
4 years, 1 month ago (2016-11-17 16:49:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508063004/1
4 years, 1 month ago (2016-11-17 16:55:37 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 17:01:20 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/431883e99a2fcdc5e6e54868ac98d3474aaaf198 Cr-Commit-Position: refs/heads/master@{#432898}
4 years, 1 month ago (2016-11-17 17:06:00 UTC) #14
Evan Stade
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2510633004/ by estade@chromium.org. ...
4 years, 1 month ago (2016-11-17 17:23:01 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508063004/20001
4 years, 1 month ago (2016-11-17 20:45:05 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-17 21:42:48 UTC) #24
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 21:48:44 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7c8b9453199a880668feab3a3f1bf39ca603a447
Cr-Commit-Position: refs/heads/master@{#432971}

Powered by Google App Engine
This is Rietveld 408576698