Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 2508043002: MD WebUI: Fix appearance of toolbar title in certain languages (Closed)

Created:
4 years, 1 month ago by tsergeant
Modified:
4 years, 1 month ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, asanka, chrome-apps-syd-reviews_chromium.org, chromium-reviews, dbeam+watch-downloads_chromium.org, dbeam+watch-elements_chromium.org, dbeam+watch-history_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, michaelpg+watch-elements_chromium.org, oshima+watch_chromium.org, pam+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD WebUI: Fix appearance of toolbar title in certain languages * Workaround font rendering issue in Hindi by adding padding to the end of the text. * Fix incorrect order-of-operations in the calculation for title width, which could cause title text to overlap with the search bar. BUG=665406 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/1e4fcf3a14c3bd8b581f726d60c9aa58e9ec7254 Cr-Commit-Position: refs/heads/master@{#433065}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rearrange padding to simplify calc(), add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M chrome/browser/resources/md_downloads/toolbar.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 1 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/resources/md_history/app.vulcanized.html View 1 3 chunks +4 lines, -2 lines 0 comments Download
M ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html View 1 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
tsergeant
Please take a look!
4 years, 1 month ago (2016-11-17 04:21:31 UTC) #3
dpapad
LGTM https://codereview.chromium.org/2508043002/diff/1/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html File ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html (right): https://codereview.chromium.org/2508043002/diff/1/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html#newcode61 ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html:61: max-width: calc((100% - var(--cr-toolbar-field-width)) / 2 - 18px); ...
4 years, 1 month ago (2016-11-17 18:49:30 UTC) #8
tsergeant
https://codereview.chromium.org/2508043002/diff/1/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html File ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html (right): https://codereview.chromium.org/2508043002/diff/1/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html#newcode61 ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html:61: max-width: calc((100% - var(--cr-toolbar-field-width)) / 2 - 18px); On ...
4 years, 1 month ago (2016-11-18 00:03:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508043002/20001
4 years, 1 month ago (2016-11-18 02:59:07 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-18 03:39:48 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 03:42:15 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1e4fcf3a14c3bd8b581f726d60c9aa58e9ec7254
Cr-Commit-Position: refs/heads/master@{#433065}

Powered by Google App Engine
This is Rietveld 408576698