MD WebUI: Fix appearance of toolbar title in certain languages

MD WebUI: Fix appearance of toolbar title in certain languages

* Workaround font rendering issue in Hindi by adding padding to the end
  of the text.
* Fix incorrect order-of-operations in the calculation for title width,
  which could cause title text to overlap with the search bar.

BUG=665406
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/1e4fcf3a14c3bd8b581f726d60c9aa58e9ec7254
Cr-Commit-Position: refs/heads/master@{#433065}

[tsergeant, 2016-11-17 00:47:23]

Description was changed from

==========
MD WebUI: Fix appearance of toolbar title in certain languages

* Workaround font rendering issue in Hindi by adding padding to the end
  of the text.
* Fix incorrect order-of-operations in the calculation for title width,
  which could cause title text to overlap with the search bar.

BUG=665406
==========

to

==========
MD WebUI: Fix appearance of toolbar title in certain languages

* Workaround font rendering issue in Hindi by adding padding to the end
  of the text.
* Fix incorrect order-of-operations in the calculation for title width,
  which could cause title text to overlap with the search bar.

BUG=665406
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-11-17 04:21:30]

tsergeant@chromium.org changed reviewers:
+ dpapad@chromium.org

[tsergeant, 2016-11-17 04:21:31]

Please take a look!

[tsergeant, 2016-11-17 04:21:35]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 04:22:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 04:34:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 04:34:40]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[dpapad, 2016-11-17 18:49:30]

LGTM

https://codereview.chromium.org/2508043002/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html (right):

https://codereview.chromium.org/2508043002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html:61: max-width:
calc((100% - var(--cr-toolbar-field-width)) / 2 - 18px);
Can you add a comment explaining the rationale of this calculation? It is not
obvious.

[tsergeant, 2016-11-18 00:01:47]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[tsergeant, 2016-11-18 00:03:06]

https://codereview.chromium.org/2508043002/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html (right):

https://codereview.chromium.org/2508043002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html:61: max-width:
calc((100% - var(--cr-toolbar-field-width)) / 2 - 18px);
On 2016/11/17 18:49:29, dpapad wrote:
> Can you add a comment explaining the rationale of this calculation? It is not
> obvious.

Done. In the process, I realised I could change the box sizing to get rid of the
18px magic number, so I've done that too.

[commit-bot: I haz the power, 2016-11-18 00:04:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 02:49:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 02:49:40]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2016-11-18 02:57:13]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2016-11-18 02:57:13]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2508043002/#ps20001
(title: "Rearrange padding to simplify calc(), add comment")

[commit-bot: I haz the power, 2016-11-18 02:59:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 03:39:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-18 03:42:13]

Description was changed from

==========
MD WebUI: Fix appearance of toolbar title in certain languages

* Workaround font rendering issue in Hindi by adding padding to the end
  of the text.
* Fix incorrect order-of-operations in the calculation for title width,
  which could cause title text to overlap with the search bar.

BUG=665406
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD WebUI: Fix appearance of toolbar title in certain languages

* Workaround font rendering issue in Hindi by adding padding to the end
  of the text.
* Fix incorrect order-of-operations in the calculation for title width,
  which could cause title text to overlap with the search bar.

BUG=665406
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/1e4fcf3a14c3bd8b581f726d60c9aa58e9ec7254
Cr-Commit-Position: refs/heads/master@{#433065}
==========

[commit-bot: I haz the power, 2016-11-18 03:42:15]

Patchset 2 (id:??) landed as
https://crrev.com/1e4fcf3a14c3bd8b581f726d60c9aa58e9ec7254
Cr-Commit-Position: refs/heads/master@{#433065}