Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 250803018: Revert 266437 "Reland of 260688: [Files.app] Use getDriveEntryPr..." (Closed)

Created:
6 years, 7 months ago by yoshiki
Modified:
6 years, 7 months ago
Reviewers:
yoshiki
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 266437 "Reland of 260688: [Files.app] Use getDriveEntryPr..." > Reland of 260688: [Files.app] Use getDriveEntryProperties() to retrieve metadata > > This is a reland of 260688, which is reverted due to false charge of build failure. > > Previously, we used FileEntry.getMetadata() to retrieve filesystem metadata and getDriveEntryProperties() to get Drive metadata, so we need 2 calls for 1 file on Drive. > > With this patch, getDriveEntryProperties() returns not only Drive metadata but also filesystem metadata. It's enough to call only getDriveEntryProperties() and we can reduce a number of calls by half. > > BUG=345196 > TEST=browser_test passes. > R=asargent@chromium.org, hashimoto@chromium.org, hirono@chromium.org > TBR=asargent@chromium.org, hashimoto@chromium.org, hirono@chromium.org > > Review URL: https://codereview.chromium.org/195763004 TBR=yoshiki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266498

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -14 lines) Patch
M trunk/src/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M trunk/src/chrome/common/extensions/api/file_browser_private.idl View 1 chunk +0 lines, -6 lines 0 comments Download
M trunk/src/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
yoshiki
6 years, 7 months ago (2014-04-28 09:58:03 UTC) #1
yoshiki
6 years, 7 months ago (2014-04-28 09:58:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r266498 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698