chrome/browser/managed_mode/managed_mode_navigation_observer.cc - Issue 250803004: Cleanup: Refactor ManagedModeInterstitial to not "delete this" in the ctor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/managed_mode/managed_mode_navigation_observer.cc

Issue 250803004: Cleanup: Refactor ManagedModeInterstitial to not "delete this" in the ctor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review comments. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/managed_mode/managed_mode_navigation_observer.cc

diff --git a/chrome/browser/managed_mode/managed_mode_navigation_observer.cc b/chrome/browser/managed_mode/managed_mode_navigation_observer.cc

index ef33758df7762e5fe38666ad8c733dd6f75c9eb6..12cb5b2feced2438e6702d80e082c6e6d2b90f2a 100644

--- a/chrome/browser/managed_mode/managed_mode_navigation_observer.cc

+++ b/chrome/browser/managed_mode/managed_mode_navigation_observer.cc

@@ -233,7 +233,7 @@ void ManagedModeNavigationObserver::OnRequestBlocked(

navigation_observer->OnRequestBlockedInternal(url);

// Show the interstitial.

- new ManagedModeInterstitial(web_contents, url, callback);

+ ManagedModeInterstitial::Show(web_contents, url, callback);

}

void ManagedModeNavigationObserver::OnRequestBlockedInternal(const GURL& url) {

« no previous file with comments | « chrome/browser/managed_mode/managed_mode_interstitial.cc ('k') | no next file » | no next file with comments »