Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 2507973002: Fix an issue that "download pending" is showing for download with unknown size (Closed)

Created:
4 years, 1 month ago by qinmin
Modified:
4 years, 1 month ago
Reviewers:
gone
CC:
chromium-reviews, asanka, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix an issue that "download pending" is showing for download with unknown size DownloadNotificationService currently cannot differentiate pending download from download with unknown sizes. This CL fixes the issue. BUG=666069 Committed: https://crrev.com/d07641f34f029fcbb20f016c179e68bb6e70a250 Cr-Commit-Position: refs/heads/master@{#432697}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -12 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java View 5 chunks +47 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
qinmin
PTAL
4 years, 1 month ago (2016-11-16 22:22:18 UTC) #2
gone
lgtm
4 years, 1 month ago (2016-11-16 22:33:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507973002/1
4 years, 1 month ago (2016-11-16 23:00:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 01:56:14 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 02:07:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d07641f34f029fcbb20f016c179e68bb6e70a250
Cr-Commit-Position: refs/heads/master@{#432697}

Powered by Google App Engine
This is Rietveld 408576698