Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: cc/resources/resource_pool_unittest.cc

Issue 2507963003: Pass correct texture hint for GPU raster (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/resources/resource_pool.cc ('k') | cc/resources/resource_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/resources/resource_pool_unittest.cc
diff --git a/cc/resources/resource_pool_unittest.cc b/cc/resources/resource_pool_unittest.cc
index 3a82131d2776286e90353b25156a5107f57fe504..3b1c5b7e0450cd333a479fe952d443d47ba2452c 100644
--- a/cc/resources/resource_pool_unittest.cc
+++ b/cc/resources/resource_pool_unittest.cc
@@ -28,6 +28,7 @@ class ResourcePoolTest : public testing::Test {
task_runner_ = base::ThreadTaskRunnerHandle::Get();
resource_pool_ =
ResourcePool::Create(resource_provider_.get(), task_runner_.get(),
+ ResourceProvider::TEXTURE_HINT_IMMUTABLE,
ResourcePool::kDefaultExpirationDelay);
}
@@ -158,6 +159,7 @@ TEST_F(ResourcePoolTest, BusyResourcesEventuallyFreed) {
// to run.
resource_pool_ =
ResourcePool::Create(resource_provider_.get(), task_runner_.get(),
+ ResourceProvider::TEXTURE_HINT_IMMUTABLE,
base::TimeDelta::FromMilliseconds(10));
// Limits high enough to not be hit by this test.
@@ -198,6 +200,7 @@ TEST_F(ResourcePoolTest, UnusedResourcesEventuallyFreed) {
// to run.
resource_pool_ =
ResourcePool::Create(resource_provider_.get(), task_runner_.get(),
+ ResourceProvider::TEXTURE_HINT_IMMUTABLE,
base::TimeDelta::FromMilliseconds(100));
// Limits high enough to not be hit by this test.
@@ -367,4 +370,27 @@ TEST_F(ResourcePoolTest, MemoryStateSuspended) {
EXPECT_EQ(0u, resource_pool_->GetBusyResourceCountForTesting());
}
+TEST_F(ResourcePoolTest, TextureHintRespected) {
+ gfx::Size size(100, 100);
+ ResourceFormat format = RGBA_8888;
+ gfx::ColorSpace color_space;
+
+ resource_pool_ =
+ ResourcePool::Create(resource_provider_.get(), task_runner_.get(),
+ ResourceProvider::TEXTURE_HINT_IMMUTABLE,
+ base::TimeDelta::FromMilliseconds(100));
+ Resource* resource =
+ resource_pool_->AcquireResource(size, format, color_space);
+ EXPECT_TRUE(resource_provider_->IsImmutable(resource->id()));
+ resource_pool_->ReleaseResource(resource);
+
+ resource_pool_ =
+ ResourcePool::Create(resource_provider_.get(), task_runner_.get(),
+ ResourceProvider::TEXTURE_HINT_DEFAULT,
+ base::TimeDelta::FromMilliseconds(100));
+ resource = resource_pool_->AcquireResource(size, format, color_space);
+ EXPECT_FALSE(resource_provider_->IsImmutable(resource->id()));
+ resource_pool_->ReleaseResource(resource);
+}
+
} // namespace cc
« no previous file with comments | « cc/resources/resource_pool.cc ('k') | cc/resources/resource_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698