Move PlatformDisplayDefault into it's own file.

Move PlatformDisplayDefault into it's own file.

Fix style guide violation and unclutter the interface definition. Also
remove many unnecessary forward defs and #includes.

BUG=663907
Committed: https://crrev.com/72899e193d84abbce528ef62df45aef3fd699e83
Cr-Commit-Position: refs/heads/master@{#432879}

[kylechar, 2016-11-16 21:01:20]

kylechar@chromium.org changed reviewers:
+ msw@chromium.org

[msw, 2016-11-16 22:52:08]

lgtm with minor nits

https://codereview.chromium.org/2507943002/diff/1/services/ui/ws/platform_dis...
File services/ui/ws/platform_display_default.h (right):

https://codereview.chromium.org/2507943002/diff/1/services/ui/ws/platform_dis...
services/ui/ws/platform_display_default.h:16: #include
"ui/platform_window/platform_window.h"
optional nit: restore fwd decl and move include to cc file.

https://codereview.chromium.org/2507943002/diff/1/services/ui/ws/platform_dis...
services/ui/ws/platform_display_default.h:25: // PlatformDisplay implementation
that connects to a PlatformWindow for CrOS
nit: trailing period

https://codereview.chromium.org/2507943002/diff/1/services/ui/ws/platform_dis...
services/ui/ws/platform_display_default.h:90: #endif  //
SERVICES_UI_WS_PLATFORM_DISPLAY_DEFAULT_H_
nit: blank line above

[kylechar, 2016-11-17 14:00:06]

Thanks msw!

https://codereview.chromium.org/2507943002/diff/1/services/ui/ws/platform_dis...
File services/ui/ws/platform_display_default.h (right):

https://codereview.chromium.org/2507943002/diff/1/services/ui/ws/platform_dis...
services/ui/ws/platform_display_default.h:16: #include
"ui/platform_window/platform_window.h"
On 2016/11/16 22:52:08, msw wrote:
> optional nit: restore fwd decl and move include to cc file.

Done.

https://codereview.chromium.org/2507943002/diff/1/services/ui/ws/platform_dis...
services/ui/ws/platform_display_default.h:25: // PlatformDisplay implementation
that connects to a PlatformWindow for CrOS
On 2016/11/16 22:52:08, msw wrote:
> nit: trailing period

Done.

https://codereview.chromium.org/2507943002/diff/1/services/ui/ws/platform_dis...
services/ui/ws/platform_display_default.h:90: #endif  //
SERVICES_UI_WS_PLATFORM_DISPLAY_DEFAULT_H_
On 2016/11/16 22:52:08, msw wrote:
> nit: blank line above

Done.

[kylechar, 2016-11-17 14:00:11]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 14:00:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 15:04:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 15:04:12]

Dry run: This issue passed the CQ dry run.

[kylechar, 2016-11-17 15:04:49]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-11-17 15:04:49]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2507943002/#ps20001
(title: "Fixes.")

[commit-bot: I haz the power, 2016-11-17 15:05:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 15:09:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 15:11:48]

Description was changed from

==========
Move PlatformDisplayDefault into it's own file.

Fix style guide violation and unclutter the interface definition. Also
remove many unnecessary forward defs and #includes.

BUG=663907
==========

to

==========
Move PlatformDisplayDefault into it's own file.

Fix style guide violation and unclutter the interface definition. Also
remove many unnecessary forward defs and #includes.

BUG=663907

Committed: https://crrev.com/72899e193d84abbce528ef62df45aef3fd699e83
Cr-Commit-Position: refs/heads/master@{#432879}
==========

[commit-bot: I haz the power, 2016-11-17 15:11:49]

Patchset 2 (id:??) landed as
https://crrev.com/72899e193d84abbce528ef62df45aef3fd699e83
Cr-Commit-Position: refs/heads/master@{#432879}