Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2507933003: [ios] Implements more of ChromiumBrowserProvider. (Closed)

Created:
4 years, 1 month ago by rohitrao (ping after 24h)
Modified:
4 years, 1 month ago
Reviewers:
sdefresne
CC:
chromium-reviews, mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Implements more of ChromiumBrowserProvider. BUG=666375 Committed: https://crrev.com/bf9201e200fcdb2d36f269dc0ddcd1a000265d1b Cr-Commit-Position: refs/heads/master@{#432911}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -2 lines) Patch
M ios/chrome/browser/providers/chromium_browser_provider.h View 1 chunk +11 lines, -1 line 0 comments Download
M ios/chrome/browser/providers/chromium_browser_provider.mm View 1 chunk +34 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
rohitrao (ping after 24h)
Empty implementations of these providers seem ok for now. We may need to add "chromium" ...
4 years, 1 month ago (2016-11-17 17:45:15 UTC) #4
sdefresne
lgtm
4 years, 1 month ago (2016-11-17 17:47:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507933003/1
4 years, 1 month ago (2016-11-17 17:55:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 18:05:27 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 18:12:21 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf9201e200fcdb2d36f269dc0ddcd1a000265d1b
Cr-Commit-Position: refs/heads/master@{#432911}

Powered by Google App Engine
This is Rietveld 408576698