Issue 250793009: Merge v8converions with conversions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 250793009: Merge v8converions with conversions (Closed)

Created:
6 years, 7 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 7 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Merge v8converions with conversions BUG=none R=mstarzinger@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=21005

Patch Set 2 : updates #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+155 lines, -226 lines)			Patch
M	src/conversions.h	View		2 chunks	+76 lines, -0 lines	0 comments	Download
M	src/conversions.cc	View	1	3 chunks	+64 lines, -0 lines	0 comments	Download
M	src/elements.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/factory.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/heap.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	src/heap-snapshot-generator.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/hydrogen-instructions.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/ic.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/incremental-marking.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/json-parser.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/json-stringifier.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/property-details-inl.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/runtime.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	src/uri.h	View		1 chunk	+1 line, -1 line	0 comments	Download
D	src/v8conversions.h	View		1 chunk	+0 lines, -109 lines	0 comments	Download
D	src/v8conversions.cc	View		1 chunk	+0 lines, -100 lines	0 comments	Download
M	tools/gyp/v8.gyp	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM. https://codereview.chromium.org/250793009/diff/1/src/conversions.cc File src/conversions.cc (right): https://codereview.chromium.org/250793009/diff/1/src/conversions.cc#newcode93 src/conversions.cc:93: nit: Two lines of white-space ought'a be enough ...

6 years, 7 months ago (2014-04-28 08:39:15 UTC) #2

jochen (gone - plz use gerrit)

6 years, 7 months ago (2014-04-28 09:14:49 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r21005 (presubmit successful).

Expand Messages | Collapse Messages

Issue 250793009: Merge v8converions with conversions (Closed)

Description

Patch Set 1 #

Patch Set 2 : updates #

Messages