Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 250793005: Refactor Udev device support in Ozone and add a DRM hotplug monitor (Closed)

Created:
6 years, 8 months ago by dnicoara
Modified:
6 years, 7 months ago
Reviewers:
spang
CC:
chromium-reviews, rjkroege, ozone-reviews_chromium.org, tdresser+watch_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org
Visibility:
Public.

Description

Refactor Udev device support in Ozone and add a DRM hotplug monitor To detect display hotplug events this CL is refactoring how the Udev connection is shared between the different Ozone components. Now multiple monitors can be registered with a central Udev device. The monitors then get Udev device events which can be parsed into native events or notifications. BUG=333413 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267247

Patch Set 1 #

Patch Set 2 : Add comments #

Patch Set 3 : . #

Patch Set 4 : . #

Total comments: 5

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Patch Set 10 : . #

Patch Set 11 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+551 lines, -433 lines) Patch
M ui/events/events.gyp View 1 2 3 4 5 6 7 3 chunks +12 lines, -7 lines 0 comments Download
A ui/events/ozone/device/device_event.h View 1 2 3 4 5 6 7 8 1 chunk +43 lines, -0 lines 0 comments Download
A ui/events/ozone/device/device_event.cc View 1 2 3 4 5 6 7 1 chunk +16 lines, -0 lines 0 comments Download
A ui/events/ozone/device/device_event_observer.h View 1 2 3 4 5 6 7 1 chunk +24 lines, -0 lines 0 comments Download
A ui/events/ozone/device/device_manager.h View 1 2 3 4 5 6 7 1 chunk +36 lines, -0 lines 0 comments Download
A ui/events/ozone/device/device_manager.cc View 1 2 3 4 5 6 7 1 chunk +20 lines, -0 lines 0 comments Download
A ui/events/ozone/device/device_manager_manual.h View 1 2 3 4 5 6 7 1 chunk +29 lines, -0 lines 0 comments Download
A ui/events/ozone/device/device_manager_manual.cc View 1 2 3 4 5 6 7 1 chunk +33 lines, -0 lines 0 comments Download
A ui/events/ozone/device/udev/device_manager_udev.h View 1 2 3 4 5 6 7 1 chunk +48 lines, -0 lines 0 comments Download
A ui/events/ozone/device/udev/device_manager_udev.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +179 lines, -0 lines 0 comments Download
A + ui/events/ozone/device/udev/scoped_udev.h View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -3 lines 0 comments Download
M ui/events/ozone/evdev/device_manager_evdev.h View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -38 lines 0 comments Download
D ui/events/ozone/evdev/device_manager_evdev.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -43 lines 0 comments Download
M ui/events/ozone/evdev/device_manager_udev.h View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -19 lines 0 comments Download
M ui/events/ozone/evdev/device_manager_udev.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -217 lines 0 comments Download
M ui/events/ozone/evdev/event_factory_evdev.h View 1 2 3 4 5 6 7 8 9 3 chunks +18 lines, -8 lines 0 comments Download
M ui/events/ozone/evdev/event_factory_evdev.cc View 1 2 3 4 5 6 7 8 9 10 5 chunks +46 lines, -40 lines 0 comments Download
D ui/events/ozone/evdev/scoped_udev.h View 1 chunk +0 lines, -50 lines 0 comments Download
M ui/ozone/ozone.gyp View 1 2 3 4 5 6 7 1 chunk +5 lines, -0 lines 0 comments Download
M ui/ozone/platform/dri/chromeos/native_display_delegate_dri.h View 1 2 3 4 5 6 7 2 chunks +11 lines, -2 lines 0 comments Download
M ui/ozone/platform/dri/chromeos/native_display_delegate_dri.cc View 1 2 3 4 5 6 7 4 chunks +20 lines, -3 lines 0 comments Download
M ui/ozone/platform/dri/ozone_platform_dri.cc View 1 2 3 4 5 6 7 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
dnicoara
6 years, 8 months ago (2014-04-25 18:54:57 UTC) #1
spang
It should be possible to share the socket and union all the filters. Possible improvement ...
6 years, 8 months ago (2014-04-25 19:50:22 UTC) #2
spang
https://codereview.chromium.org/250793005/diff/60001/ui/events/ozone/device_udev.h File ui/events/ozone/device_udev.h (right): https://codereview.chromium.org/250793005/diff/60001/ui/events/ozone/device_udev.h#newcode1 ui/events/ozone/device_udev.h:1: // Copyright 2014 The Chromium Authors. All rights reserved. ...
6 years, 8 months ago (2014-04-25 19:50:28 UTC) #3
spang
https://codereview.chromium.org/250793005/diff/60001/ui/ozone/platform/dri/ozone_platform_dri.cc File ui/ozone/platform/dri/ozone_platform_dri.cc (right): https://codereview.chromium.org/250793005/diff/60001/ui/ozone/platform/dri/ozone_platform_dri.cc#newcode18 ui/ozone/platform/dri/ozone_platform_dri.cc:18: #if defined(USE_UDEV) OS_CHROMEOS implies USE_UDEV
6 years, 8 months ago (2014-04-25 19:52:26 UTC) #4
spang
https://codereview.chromium.org/250793005/diff/60001/ui/events/ozone/monitor_udev.h File ui/events/ozone/monitor_udev.h (right): https://codereview.chromium.org/250793005/diff/60001/ui/events/ozone/monitor_udev.h#newcode14 ui/events/ozone/monitor_udev.h:14: // DeviceUdev and receive events when changes to devices ...
6 years, 8 months ago (2014-04-25 20:42:06 UTC) #5
dnicoara
PTAL I've modified the abstraction to remove some of the #ifdefs. Let me know what ...
6 years, 7 months ago (2014-04-29 18:43:16 UTC) #6
spang
lgtm
6 years, 7 months ago (2014-04-29 19:01:00 UTC) #7
dnicoara
The CQ bit was checked by dnicoara@chromium.org
6 years, 7 months ago (2014-04-30 16:42:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/250793005/200001
6 years, 7 months ago (2014-04-30 16:43:43 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 17:02:11 UTC) #10
Message was sent while issue was closed. 
Change committed as 267247

Powered by Google App Engine
This is Rietveld 408576698