Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 250793004: Remove builtin_padding from LocationBarLayout (Closed)

Created:
6 years, 8 months ago by oshima
Modified:
6 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, Use pkasting(at)chromium.org
Visibility:
Public.

Description

Remove builtin_padding from LocationBarLayout This depends on https://codereview.chromium.org/247193002/ BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266456

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -42 lines) Patch
M chrome/browser/ui/views/location_bar/location_bar_layout.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_layout.cc View 8 chunks +8 lines, -20 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 3 chunks +12 lines, -19 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
oshima
6 years, 8 months ago (2014-04-25 14:30:06 UTC) #1
sky
LGTM
6 years, 8 months ago (2014-04-25 15:47:19 UTC) #2
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 8 months ago (2014-04-26 01:24:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/250793004/40001
6 years, 8 months ago (2014-04-26 02:04:51 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 02:21:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 8 months ago (2014-04-26 02:21:12 UTC) #6
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 8 months ago (2014-04-26 14:03:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/250793004/40001
6 years, 8 months ago (2014-04-26 14:04:28 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 06:58:57 UTC) #9
Message was sent while issue was closed. 
Change committed as 266456

Powered by Google App Engine
This is Rietveld 408576698