Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 250793002: Revert of Add support for more ASAN errors generation to chrome://crash/... (Closed)

Created:
6 years, 8 months ago by Sébastien Marchand
Modified:
6 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Add support for more ASAN errors generation to chrome://crash/... (https://codereview.chromium.org/247543002/) Reason for revert: This break the debug build. Original issue's description: > Add support for more ASAN errors generation to chrome://crash/... > > Adds the following crash url to chrome/chromium builds when SYZYASAN is defined (built with syzyasan=1 in GYP_DEFINES): > heap-corrupted-block > > This allows easy validation of the instrumentation/reporting for a given build without having to track down a known/unfixed memory error. > > > R=chrisha@chromium.org > > BUG= > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265942 TBR=chrisha@chromium.org,jochen@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266101

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -32 lines) Patch
M content/renderer/render_frame_impl.cc View 3 chunks +0 lines, -32 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Sébastien Marchand
Created Revert of Add support for more ASAN errors generation to chrome://crash/...
6 years, 8 months ago (2014-04-25 02:01:26 UTC) #1
Sébastien Marchand
I'm not a committer so I'm not sure that this revert will work...
6 years, 8 months ago (2014-04-25 02:06:12 UTC) #2
Sébastien Marchand
I'm not a committer so I'm not sure that this revert will work...
6 years, 8 months ago (2014-04-25 02:06:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sebmarchand@chromium.org/250793002/1
6 years, 8 months ago (2014-04-25 02:07:18 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 02:07:19 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 8 months ago (2014-04-25 02:07:19 UTC) #6
iannucci
rslgtm
6 years, 8 months ago (2014-04-25 02:10:11 UTC) #7
Sébastien Marchand
The CQ bit was checked by sebmarchand@chromium.org
6 years, 8 months ago (2014-04-25 02:11:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sebmarchand@chromium.org/250793002/1
6 years, 8 months ago (2014-04-25 02:15:18 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 02:55:11 UTC) #10
Message was sent while issue was closed.
Change committed as 266101

Powered by Google App Engine
This is Rietveld 408576698