Issue 25079006: Update CSSAnimationUpdate and CSSAnimations to handle multiple animations with a given name

Issue 25079006: Update CSSAnimationUpdate and CSSAnimations to handle multiple animations with a given name (Closed)

Created:
7 years, 2 months ago by Steve Block

Modified:
7 years, 2 months ago

Reviewers:
dstockwell

CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dglazkov+blink, dstockwell, Timothy Loh, apavlov+blink_chromium.org, darktears, Steve Block, dino_apple.com, Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Update CSSAnimationUpdate and CSSAnimations to handle multiple animations with a given name This will be required to handle CSS animations with incomplete keyframes, which we will handle by splitting the animation up into multiple InertAnimation objects. Uploading this preparatory work as a separate change to simplify the change for incomplete keyframes. No functional change. BUG=240653 R=dstockwell Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158516

Patch Set 1 #

Patch Set 2 : Minor fixes #

Total comments: 2

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -29 lines)			Patch
M	Source/core/animation/InertAnimation.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/animation/css/CSSAnimations.h	View	1	2 chunks	+15 lines, -7 lines	0 comments	Download
M	Source/core/animation/css/CSSAnimations.cpp	View	1	2 chunks	+20 lines, -8 lines	2 comments	Download
M	Source/core/css/resolver/StyleResolver.cpp	View	1	1 chunk	+15 lines, -13 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/25079006/4001

7 years, 2 months ago (2013-09-30 05:26:20 UTC) #3

dstockwell

https://codereview.chromium.org/25079006/diff/4001/Source/core/animation/css/CSSAnimations.cpp File Source/core/animation/css/CSSAnimations.cpp (right): https://codereview.chromium.org/25079006/diff/4001/Source/core/animation/css/CSSAnimations.cpp#newcode226 Source/core/animation/css/CSSAnimations.cpp:226: RefPtr<Animation> animation = Animation::create(element, inertAnimation->effect(), inertAnimation->specified(), eventDelegate.release()); Missed this ...

7 years, 2 months ago (2013-09-30 07:30:30 UTC) #5

Steve Block

7 years, 2 months ago (2013-09-30 11:36:06 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/25079006/diff/4001/Source/core/animation/css/...
File Source/core/animation/css/CSSAnimations.cpp (right):

https://codereview.chromium.org/25079006/diff/4001/Source/core/animation/css/...
Source/core/animation/css/CSSAnimations.cpp:226: RefPtr<Animation> animation =
Animation::create(element, inertAnimation->effect(),
inertAnimation->specified(), eventDelegate.release());
Added a comment in https://codereview.chromium.org/25040006/

Expand Messages | Collapse Messages