third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-composited-row.html - Issue 2507893002: Fix painting background for composited table cells in a non-composited row.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-composited-row.html

Issue 2507893002: Fix painting background for composited table cells in a non-composited row. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <script src="../resources/text-based-repaint.js"></script>

	3 <script>

	4 function repaintTest() {

	5 target.style.backgroundColor = 'lightBlue';

	6 }

	7 onload = runRepaintAndPixelTest;

	8 </script>

	9 <style>

	10 td {

	11 padding: 0 24px;

	12 height: 64px;

	13 }

	14 </style>

	15 Test passes if all of the cells in the second row of the table have a blue backg round.

	16 <table>
	wkorman 2016/11/16 20:15:46 This test is intended to validate your comment fro This test is intended to validate your comment from https://codereview.chromium.org/2469903002 re: "It should also be able to correctly handle the case that a row is composited but the intersecting col and section don't have background.". It's the same as the base paint/invalidation/table/composited-table-background.html test except that the second row is composited. If I've misinterpreted in some way let me know. Also all tests have two cases, the base one where initially the background area in question is red, and a variant with -initial-empty.html where the background area is initially not set. This is to validate that we deal gracefully with the case where we don't need to create the special display item client initially, but we do need it later on style background change.
	17 <tr>

	18 <td>A</td>

	19 <td>B</td>

	20 <td>C</td>

	21 </tr>

	22 <tr id="target" style="will-change: transform; background-color: red">

	23 <td>D</td>

	24 <td style="will-change: transform;">E</td>

	25 <td>F</td>

	26 </tr>

	27 </table>

OLD	NEW