Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2507883002: Bit width analysis for avoiding conversion of bitops to unsigned. (Closed)

Created:
4 years, 1 month ago by sra1
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : reformat #

Patch Set 3 : Redo "Bit width analysis for avoiding conversion of bitops to unsigned." #

Patch Set 4 : Fix warnings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
M pkg/compiler/lib/src/ssa/codegen.dart View 1 2 3 2 chunks +52 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sra1
I have has this lying around for a while. This is essentially the same analysis ...
4 years, 1 month ago (2016-11-16 19:23:48 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 1 month ago (2016-11-16 19:31:15 UTC) #3
sra1
4 years, 1 month ago (2016-11-16 21:37:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a5443a8b0d983eda457996b8534646154a59c334 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698