Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2507873003:
Allow adding user and launching guest mode when all profiles are lock while force sign in is enable… (Closed)
DescriptionAllow adding user and launching guest mode when all profiles are lock while force sign in is enabled.
Guest mode is desgined for the use case that all profiles are locked when force signed in is enabled. So that user can still use it to look for help from helpdesk with out sign in. It's off by default and can only be turned on via policy.
Allow adding user when all profiles are locked so that user can create and sign in a new profile while the existed ones have been used by other account.
BUG=642059
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/f20f77c5f05c4db5c09ad5bb421b23e5f1e1029c
Cr-Commit-Position: refs/heads/master@{#433112}
Patch Set 1 #
Total comments: 6
Patch Set 2 : tommycli's comments #
Messages
Total messages: 22 (15 generated)
Description was changed from ========== Allow adding user and launching guest mode when all profiles are lock while force sign in is enabled. Guest mode is desgined for the use case that all profiles are locked when force signed in is enabled. So that user can still use it to look for help from helpdesk with out sign in. It's off by default and can only be turned on via policy. Allow adding user when all profiles are locked so that user can create and sign in a new profile while the existed ones have been used by other account. BUG=642059 ========== to ========== Allow adding user and launching guest mode when all profiles are lock while force sign in is enabled. Guest mode is desgined for the use case that all profiles are locked when force signed in is enabled. So that user can still use it to look for help from helpdesk with out sign in. It's off by default and can only be turned on via policy. Allow adding user when all profiles are locked so that user can create and sign in a new profile while the existed ones have been used by other account. BUG=642059 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
zmin@chromium.org changed reviewers: + tommycli@chromium.org
Hi Tommy, Can you please review this CL? Thanks, Owen
The CQ bit was checked by zmin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Allow adding user and launching guest mode when all profiles are lock while force sign in is enabled. Guest mode is desgined for the use case that all profiles are locked when force signed in is enabled. So that user can still use it to look for help from helpdesk with out sign in. It's off by default and can only be turned on via policy. Allow adding user when all profiles are locked so that user can create and sign in a new profile while the existed ones have been used by other account. BUG=642059 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Allow adding user and launching guest mode when all profiles are lock while force sign in is enabled. Guest mode is desgined for the use case that all profiles are locked when force signed in is enabled. So that user can still use it to look for help from helpdesk with out sign in. It's off by default and can only be turned on via policy. Allow adding user when all profiles are locked so that user can create and sign in a new profile while the existed ones have been used by other account. BUG=642059 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
cc chrome-enterprise-changes@
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
lgtm except these nits: https://codereview.chromium.org/2507873003/diff/1/chrome/browser/resources/md... File chrome/browser/resources/md_user_manager/control_bar.js (right): https://codereview.chromium.org/2507873003/diff/1/chrome/browser/resources/md... chrome/browser/resources/md_user_manager/control_bar.js:41: * @private nit: can be @private {boolean} https://codereview.chromium.org/2507873003/diff/1/chrome/browser/resources/md... chrome/browser/resources/md_user_manager/control_bar.js:49: nit: extra line https://codereview.chromium.org/2507873003/diff/1/chrome/test/data/webui/md_u... File chrome/test/data/webui/md_user_manager/control_bar_tests.js (right): https://codereview.chromium.org/2507873003/diff/1/chrome/test/data/webui/md_u... chrome/test/data/webui/md_user_manager/control_bar_tests.js:120: controlBarElement.addEventListener('change-page', function(event) { You can use the listenOnce method instead, since this should only occur once. See https://cs.chromium.org/chromium/src/chrome/test/data/webui/settings/people_p... for an example.
https://codereview.chromium.org/2507873003/diff/1/chrome/browser/resources/md... File chrome/browser/resources/md_user_manager/control_bar.js (right): https://codereview.chromium.org/2507873003/diff/1/chrome/browser/resources/md... chrome/browser/resources/md_user_manager/control_bar.js:41: * @private On 2016/11/17 23:06:23, tommycli wrote: > nit: can be @private {boolean} Done. https://codereview.chromium.org/2507873003/diff/1/chrome/browser/resources/md... chrome/browser/resources/md_user_manager/control_bar.js:49: On 2016/11/17 23:06:23, tommycli wrote: > nit: extra line Done. https://codereview.chromium.org/2507873003/diff/1/chrome/test/data/webui/md_u... File chrome/test/data/webui/md_user_manager/control_bar_tests.js (right): https://codereview.chromium.org/2507873003/diff/1/chrome/test/data/webui/md_u... chrome/test/data/webui/md_user_manager/control_bar_tests.js:120: controlBarElement.addEventListener('change-page', function(event) { On 2016/11/17 23:06:23, tommycli wrote: > You can use the listenOnce method instead, since this should only occur once. > See > https://cs.chromium.org/chromium/src/chrome/test/data/webui/settings/people_p... > for an example. Done. Also did to the test case above which is the place I copy the code from.
The CQ bit was checked by zmin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by zmin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tommycli@chromium.org Link to the patchset: https://codereview.chromium.org/2507873003/#ps20001 (title: "tommycli's comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Allow adding user and launching guest mode when all profiles are lock while force sign in is enabled. Guest mode is desgined for the use case that all profiles are locked when force signed in is enabled. So that user can still use it to look for help from helpdesk with out sign in. It's off by default and can only be turned on via policy. Allow adding user when all profiles are locked so that user can create and sign in a new profile while the existed ones have been used by other account. BUG=642059 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Allow adding user and launching guest mode when all profiles are lock while force sign in is enabled. Guest mode is desgined for the use case that all profiles are locked when force signed in is enabled. So that user can still use it to look for help from helpdesk with out sign in. It's off by default and can only be turned on via policy. Allow adding user when all profiles are locked so that user can create and sign in a new profile while the existed ones have been used by other account. BUG=642059 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Allow adding user and launching guest mode when all profiles are lock while force sign in is enabled. Guest mode is desgined for the use case that all profiles are locked when force signed in is enabled. So that user can still use it to look for help from helpdesk with out sign in. It's off by default and can only be turned on via policy. Allow adding user when all profiles are locked so that user can create and sign in a new profile while the existed ones have been used by other account. BUG=642059 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Allow adding user and launching guest mode when all profiles are lock while force sign in is enabled. Guest mode is desgined for the use case that all profiles are locked when force signed in is enabled. So that user can still use it to look for help from helpdesk with out sign in. It's off by default and can only be turned on via policy. Allow adding user when all profiles are locked so that user can create and sign in a new profile while the existed ones have been used by other account. BUG=642059 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/f20f77c5f05c4db5c09ad5bb421b23e5f1e1029c Cr-Commit-Position: refs/heads/master@{#433112} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/f20f77c5f05c4db5c09ad5bb421b23e5f1e1029c Cr-Commit-Position: refs/heads/master@{#433112} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
