MD Settings search code will not assume the Advanced section exists.

chrome/browser/resources/settings/settings_main/settings_main.js

Index: chrome/browser/resources/settings/settings_main/settings_main.js
diff --git a/chrome/browser/resources/settings/settings_main/settings_main.js b/chrome/browser/resources/settings/settings_main/settings_main.js
index 35cb61094006288cd47ada3441ba0ae85e23d74c..4dc1ae05c2459c72b44875442ed967318cd67741 100644
--- a/chrome/browser/resources/settings/settings_main/settings_main.js
+++ b/chrome/browser/resources/settings/settings_main/settings_main.js
@@ -330,10 +330,11 @@ Polymer({
       setTimeout(function() {
         var whenSearchDone = settings.getSearchManager().search(
             query, assert(this.getPage_(settings.Route.BASIC)));
-        assert(
-            whenSearchDone ===
-                settings.getSearchManager().search(
-                    query, assert(this.getPage_(settings.Route.ADVANCED))));
+
+        if (cr.isChromeOS || !loadTimeData.getBoolean('isGuest')) {

[michaelpg, 2016/11/16 20:10:14]

Please use:
  if (this.pageVisibility.showAdvancedSettings !== false)
instead, or the this.showAdvancedSettings_ function.. (triple equals cuz it may
be undefined, which means "don't hide")

We shouldn't try to duplicate this logic in multiple places (already have it in
settings_ui.js).

[michaelpg, 2016/11/16 20:12:31]

Also because we mess with pageVisibility in tests sometimes.

[hcarmona, 2016/11/16 20:23:08]

Done.

+          assert(whenSearchDone === settings.getSearchManager().search(
+              query, assert(this.getPage_(settings.Route.ADVANCED))));
+        }
 
         whenSearchDone.then(function(request) {
           resolve();