Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 2507863003: Add public doc for accessing C++ enums in Java. (Closed)

Created:
4 years, 1 month ago by estevenson
Modified:
4 years, 1 month ago
Reviewers:
agrieve
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add public doc for accessing C++ enums in Java. BUG=570878 Committed: https://crrev.com/c0b135ff0d80305eea8ff3b9a2e746808c2664a5 Cr-Commit-Position: refs/heads/master@{#432885}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Line wrap @ 80 chars #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -0 lines) Patch
A docs/android_accessing_cpp_enums_in_java.md View 1 1 chunk +150 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
estevenson
ptal Andrew! https://codereview.chromium.org/2507863003/diff/1/docs/android_accessing_cpp_enums_in_java.md File docs/android_accessing_cpp_enums_in_java.md (right): https://codereview.chromium.org/2507863003/diff/1/docs/android_accessing_cpp_enums_in_java.md#newcode20 docs/android_accessing_cpp_enums_in_java.md:20: ```cpp I indented these blocks so that ...
4 years, 1 month ago (2016-11-16 22:51:10 UTC) #2
agrieve
reads great! lgtm (/w nit) https://codereview.chromium.org/2507863003/diff/1/docs/android_accessing_cpp_enums_in_java.md File docs/android_accessing_cpp_enums_in_java.md (right): https://codereview.chromium.org/2507863003/diff/1/docs/android_accessing_cpp_enums_in_java.md#newcode7 docs/android_accessing_cpp_enums_in_java.md:7: The traditional method involved ...
4 years, 1 month ago (2016-11-17 15:16:14 UTC) #3
estevenson
https://codereview.chromium.org/2507863003/diff/1/docs/android_accessing_cpp_enums_in_java.md File docs/android_accessing_cpp_enums_in_java.md (right): https://codereview.chromium.org/2507863003/diff/1/docs/android_accessing_cpp_enums_in_java.md#newcode7 docs/android_accessing_cpp_enums_in_java.md:7: The traditional method involved extracting the enum values to ...
4 years, 1 month ago (2016-11-17 15:52:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507863003/20001
4 years, 1 month ago (2016-11-17 15:53:45 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-17 16:04:15 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 16:08:21 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c0b135ff0d80305eea8ff3b9a2e746808c2664a5
Cr-Commit-Position: refs/heads/master@{#432885}

Powered by Google App Engine
This is Rietveld 408576698