Implement texture uploads from ImageBitmap with sub source.

Implement texture uploads from ImageBitmap with sub source.

BUG=639145
TEST=webgl2_conformance
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/5e15bcd4b4cbb33b155bca008c651d28b88bac3f
Cr-Commit-Position: refs/heads/master@{#432805}

[Zhenyao Mo, 2016-11-16 18:28:07]

Description was changed from

==========
Implement texture uploads from ImageBitmap with sub source.

BUG=639145
TEST=webgl2_conformance
==========

to

==========
Implement texture uploads from ImageBitmap with sub source.

BUG=639145
TEST=webgl2_conformance
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-11-17 03:12:26]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 03:13:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2016-11-17 03:33:51]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 03:34:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2016-11-17 04:26:52]

zmo@chromium.org changed reviewers:
+ kainino@chromium.org, kbr@chromium.org

[Zhenyao Mo, 2016-11-17 04:26:53]

I think this is ready for review.

PTAL

[commit-bot: I haz the power, 2016-11-17 06:47:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 06:47:12]

Dry run: This issue passed the CQ dry run.

[Ken Russell (switch to Gerrit), 2016-11-17 07:48:45]

Excellent work Mo. This looks perfect, especially given that your new tests
cover all the code paths.

LGTM. Let me CQ this now so it's landed by tomorrow.

https://codereview.chromium.org/2507863002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h
(left):

https://codereview.chromium.org/2507863002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h:469: void
texImage2D(GLenum,
I think these two texImage2D and texSubImage2D declarations should be moved up
into the section above:

"// Have to re-declare/re-define the following tex{Sub}Image2D functions
from..."

Not a big deal; this can wait for a follow-up patch.

[Ken Russell (switch to Gerrit), 2016-11-17 07:48:49]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2016-11-17 07:49:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 07:54:13]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-17 07:56:11]

Description was changed from

==========
Implement texture uploads from ImageBitmap with sub source.

BUG=639145
TEST=webgl2_conformance
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Implement texture uploads from ImageBitmap with sub source.

BUG=639145
TEST=webgl2_conformance
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/5e15bcd4b4cbb33b155bca008c651d28b88bac3f
Cr-Commit-Position: refs/heads/master@{#432805}
==========

[commit-bot: I haz the power, 2016-11-17 07:56:12]

Patchset 5 (id:??) landed as
https://crrev.com/5e15bcd4b4cbb33b155bca008c651d28b88bac3f
Cr-Commit-Position: refs/heads/master@{#432805}