Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Issue 2507863002: Implement texture uploads from ImageBitmap with sub source. (Closed)

Created:
4 years, 1 month ago by Zhenyao Mo
Modified:
4 years, 1 month ago
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement texture uploads from ImageBitmap with sub source. BUG=639145 TEST=webgl2_conformance CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/5e15bcd4b4cbb33b155bca008c651d28b88bac3f Cr-Commit-Position: refs/heads/master@{#432805}

Patch Set 1 #

Patch Set 2 : green #

Patch Set 3 : fix #

Patch Set 4 : rebase #

Patch Set 5 : rebase again #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -66 lines) Patch
M DEPS View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h View 1 2 2 chunks +0 lines, -10 lines 1 comment Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 1 2 5 chunks +20 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h View 1 3 chunks +11 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 1 7 chunks +42 lines, -22 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (10 generated)
Zhenyao Mo
I think this is ready for review. PTAL
4 years, 1 month ago (2016-11-17 04:26:53 UTC) #7
Ken Russell (switch to Gerrit)
Excellent work Mo. This looks perfect, especially given that your new tests cover all the ...
4 years, 1 month ago (2016-11-17 07:48:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507863002/80001
4 years, 1 month ago (2016-11-17 07:49:16 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2016-11-17 07:54:13 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 07:56:12 UTC) #15
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/5e15bcd4b4cbb33b155bca008c651d28b88bac3f
Cr-Commit-Position: refs/heads/master@{#432805}

Powered by Google App Engine
This is Rietveld 408576698